Make it possible to configure arrow writer - #16
Merged
Merged
Conversation
Aratz
marked this pull request as ready for review
July 9, 2026 14:00
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring Parquet writer behavior when writing Arrow RecordBatches, enabling customization of defaults like compression and batching via Arrow/Parquet writer properties.
Changes:
- Extends
write_record_batches_to_pathto accept optionalWriterPropertiespassed through toArrowWriter. - Updates internal call site(s) to pass
Nonefor default properties. - Adds unit tests to verify both round-trip correctness and that writer properties (compression) are applied.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Native Community Detection Benchmark
Details
| Benchmark suite | Current: 4aff7e0 | Previous: 3ad7da1 | Ratio |
|---|---|---|---|
bench_fast_label_propagation |
0.006131999999999999 s |
0.005437 s |
1.13 |
bench_leiden_modularity |
0.02649 s |
0.027280000000000002 s |
0.97 |
bench_leiden_modularity_medium |
19.7 s |
16.38 s |
1.20 |
bench_create_graph_from_parquet |
1.874 s |
1.787 s |
1.05 |
bench_parquet_reading |
0.4738 s |
0.45280000000000004 s |
1.05 |
bench_parquet_writing |
0.5304 s |
0.5254 s |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By default, arrow's parquet writer batches rows in groups of 2^20 rows and does not compress the data. In some cases it might be desired to tweak these settings.
This PR makes it possible to specify such parameters when writing a batch to parquet.
Related Issue(s)
Fixes: #(issue number)
Type of change
How Has This Been Tested?
Added a few tests
Rust Checklist
cargo check).cargo fmt.cargo clippyand resolved all warnings.cargo test).CHANGELOG.mdAdditional Notes