add input_reads and output_reads in report.json for single-cell-pna denoise and single-cell-pna sample-calling - #431
Merged
ptajvar merged 4 commits intoAug 4, 2026
Conversation
johandahlberg
approved these changes
Aug 4, 2026
Co-authored-by: Johan Dahlberg <johan.dahlberg@pixelgen.tech>
ptajvar
deleted the
feature/pna-2715-report-io-reads-in-denoise-and-sample-calling
branch
August 4, 2026 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input_reads and output_reads are typically reported for all steps of the PNA pipeline but they were missing in denoise and sample calling.
Fixes: PNA-2715
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce it when relevant.
PR checklist:
pyproject.tomland cited it properlyNote
Low Risk
Read-count reporting only in JSON reports and tests; no changes to denoising or sample-calling algorithms or data paths.
Overview
Adds
input_readsandoutput_readstoreport.jsonforsingle-cell-pna denoiseandsingle-cell-pna sample-calling, matching other PNA pipeline stages.For denoise, counts come from summing
reads_in_componenton the input PXL and on the written output (when denoising is off, both values are equal). For sample-calling, each per-sample report compares reads attributed to that sample’s components in the pool input vs the dehashed output; the pooledsample_calling_totalreport uses full-pool input reads and sums output reads excluding the undetermined sample.Report models, CLI wiring,
create_final_report, and tests are updated accordingly; CHANGELOG documents the addition.Reviewed by Cursor Bugbot for commit b947126. Bugbot is set up for automated code reviews on this repo. Configure here.