Skip to content

add input_reads and output_reads in report.json for single-cell-pna denoise and single-cell-pna sample-calling - #431

Merged
ptajvar merged 4 commits into
devfrom
feature/pna-2715-report-io-reads-in-denoise-and-sample-calling
Aug 4, 2026
Merged

add input_reads and output_reads in report.json for single-cell-pna denoise and single-cell-pna sample-calling#431
ptajvar merged 4 commits into
devfrom
feature/pna-2715-report-io-reads-in-denoise-and-sample-calling

Conversation

@ptajvar

@ptajvar ptajvar commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

input_reads and output_reads are typically reported for all steps of the PNA pipeline but they were missing in denoise and sample calling.

Fixes: PNA-2715

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce it when relevant.

PR checklist:

  • This comment contains a description of changes (with reason).
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If a new tool or package is included, I have updated dependencies in pyproject.toml and cited it properly
  • I have checked my code and documentation and corrected any misspellings
  • I have documented any significant changes to the code in CHANGELOG.md

Note

Low Risk
Read-count reporting only in JSON reports and tests; no changes to denoising or sample-calling algorithms or data paths.

Overview
Adds input_reads and output_reads to report.json for single-cell-pna denoise and single-cell-pna sample-calling, matching other PNA pipeline stages.

For denoise, counts come from summing reads_in_component on the input PXL and on the written output (when denoising is off, both values are equal). For sample-calling, each per-sample report compares reads attributed to that sample’s components in the pool input vs the dehashed output; the pooled sample_calling_total report uses full-pool input reads and sums output reads excluding the undetermined sample.

Report models, CLI wiring, create_final_report, and tests are updated accordingly; CHANGELOG documents the addition.

Reviewed by Cursor Bugbot for commit b947126. Bugbot is set up for automated code reviews on this repo. Configure here.

@ptajvar
ptajvar requested review from Aratz and johandahlberg August 4, 2026 09:32
Comment thread src/pixelator/pna/cli/denoise.py
Co-authored-by: Johan Dahlberg <johan.dahlberg@pixelgen.tech>
@ptajvar
ptajvar merged commit 14bbee0 into dev Aug 4, 2026
17 checks passed
@ptajvar
ptajvar deleted the feature/pna-2715-report-io-reads-in-denoise-and-sample-calling branch August 4, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants