ensure matching size schemas in filter_connected_components_by_size - #433
Merged
johandahlberg merged 1 commit intoAug 4, 2026
Conversation
ptajvar
force-pushed
the
fix/ensure-matching-size-schemas-in-filter_connected_components_by_size
branch
from
August 4, 2026 14:28
a41dd7a to
148a722
Compare
johandahlberg
approved these changes
Aug 4, 2026
johandahlberg
deleted the
fix/ensure-matching-size-schemas-in-filter_connected_components_by_size
branch
August 4, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to ensure that the schemas match when concatenating remaining component sizes and discarded component sizes in
filter_connected_components_by_size.Note
Low Risk
Localized graph filtering/statistics fix with a targeted test; no auth, data persistence, or API surface changes.
Overview
Fixes a Polars vertical concat failure when
filter_connected_components_by_sizemerges in-component sizes with early-discarded component sizes that include an extran_edgescolumn.discard_sizesfromwrite_hive_partitioned_edgelist_without_out_of_size_bound_componentscarriescomponent,n_umi, andn_edges, while sizes computed from the remaining edgelist only havecomponentandn_umi. The filter now selectscomponentandn_umifromdiscard_sizesbefore concatenation so pre-filtering component statistics stay correct without schema mismatch.A regression test covers
discard_sizesframes that includen_edges(e.g. multiplet recovery with max component size threshold).Reviewed by Cursor Bugbot for commit 148a722. Bugbot is set up for automated code reviews on this repo. Configure here.