Make uei_count optional - #436
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 51eaa3e. Configure here.
- Only select the uei column when it is present so sample calling works also without it. - Make uei_count optional in graph component recovery. When uei_count is missing, use number of edges as a proxy for number of molecules Co-authored-by: Cursor <cursoragent@cursor.com>
johandahlberg
force-pushed
the
feature/pna-3264
branch
from
August 5, 2026 07:52
51eaa3e to
de4dc73
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Make the
uei_countcolumn optional.Fixes: pna-3264
Type of change
How Has This Been Tested?
With the associated unit tests.
PR checklist:
pyproject.tomland cited it properlyNote
Low Risk
Backward-compatible schema relaxation with localized DuckDB/SQL branching; behavior when
uei_countis present is unchanged, and molecule counts without it use edge count as documented.Overview
uei_countis now optional on PNA edgelists in sample calling and graph component recovery. Edgelists that omit the column no longer fail on hard-codedSUM(uei_count)orSELECTlists.Shared helpers
has_uei_count(DuckDBDESCRIBE) andn_molecules_sql(SUM(uei_count)vsCOUNT(*)) drive the behavior. Graph recovery uses them for molecule totals inget_count_statistics, PXL build stats, andcreate_working_edgelist(the column is dropped from the working parquet when missing). Sample calling builds the dehashed edgelistCOPYwithoutuei_countwhen it is not present.CHANGELOG documents the change under Unreleased. Unit tests cover stats, working edgelist shape, and end-to-end sample calling without
uei_count.Reviewed by Cursor Bugbot for commit 5f4277f. Bugbot is set up for automated code reviews on this repo. Configure here.