Open
Conversation
Author
|
Btw, since GitHub's diff rendering is sometimes suboptimal, here's the diff using delta, which makes the changes more evident: 
|
Author
|
Alternatively, we could make CIDs be always printed with 4 hex digits, as used in https://github.com/PixlOne/logiops/wiki/CIDs. Something like this: $ sudo logid -v
[DEBUG] Unsupported device /dev/hidraw4 ignored
[DEBUG] Unsupported device /dev/hidraw1 ignored
[DEBUG] Unsupported device /dev/hidraw2 ignored
[DEBUG] Unsupported device /dev/hidraw3 ignored
[DEBUG] Unsupported device /dev/hidraw0 ignored
[INFO] Device found: MX Master 4 on /dev/hidraw5:255
[DEBUG] /dev/hidraw5:255 remappable buttons:
[DEBUG] CID | reprog? | fn key? | mouse key? | gesture support?
[DEBUG] 0x0050 | | | YES |
[DEBUG] 0x0051 | | | YES |
[DEBUG] 0x0052 | YES | | YES | YES
[DEBUG] 0x0053 | YES | | YES | YES
[DEBUG] 0x0056 | YES | | YES | YES
[DEBUG] 0x00c3 | YES | | YES | YES
[DEBUG] 0x00c4 | YES | | YES | YES
[DEBUG] 0x00d7 | YES | | | YES
[DEBUG] 0x01a0 | YES | | YES | YES
[DEBUG] Thumb wheel detected (0x2150), capabilities:
[DEBUG] timestamp | touch | proximity | single tap
[DEBUG] YES | YES | NO | NO
[DEBUG] Thumb wheel resolution: native (20), diverted (120)That would make the code simpler, and the output more consistent with the existing reference info. Let me know if that would be preferred! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #414, @wprzytula changed CIDs from
uint8_tto beuint16_tinstead, but the code that prints these values was not adapted accordingly. This patch adjust the printing code for CIDs to ensure they consider the wider length of uint_16t's hex representations.For comparison, here's the output I get with the current v0.3.5 (note the misalignment in the
0x1a0line of the "remappable buttons" table):And here's the output with these changes: