Skip to content
This repository was archived by the owner on Feb 12, 2026. It is now read-only.

LIHEDP Notebooks#68

Open
cmoissar wants to merge 1 commit into
PlasmaPy:mainfrom
cmoissar:add_LIHEDP_teaching_notebooks
Open

LIHEDP Notebooks#68
cmoissar wants to merge 1 commit into
PlasmaPy:mainfrom
cmoissar:add_LIHEDP_teaching_notebooks

Conversation

@cmoissar

Copy link
Copy Markdown
Contributor

Jupyter Notebooks from a course on Laser Plasma Interaction and High Energy Density Plasma

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cmoissar cmoissar marked this pull request as ready for review July 18, 2022 15:06
@cmoissar

Copy link
Copy Markdown
Contributor Author

Note:

I am interested in pushing some of the content of these notebooks on PlasmaPy.

I believe the core functions would need to be extracted and implemented in separate .py files.

Hopefully, some of this is of interest to you:

@cmoissar

Copy link
Copy Markdown
Contributor Author

I have a question about the difference between Pull Request and Drafts:

Can you see Drafts and comment on them?

Is it annoying for you if the Pull Request contains code that is quite rough?

@pheuer

pheuer commented Aug 7, 2022

Copy link
Copy Markdown
Member

@cmoissar drafts just have a note so we know they aren't ready to review. Absolutely no problem opening a PR even when rough - it allows us to easily see what you're working on and give suggestions.

I think adding some functions for LP HEDP and an example notebook that features them would be great! I would do at as 1 PR per function and then 1 PR for the notebook. If you're still interested, you should open those PRs on the main PlasmaPy package.

@JaydenR2305

Copy link
Copy Markdown
Member

Hey @cmoissar, do you mind if I take a stab at implementing the plasma critical density formulary as my first commit?

@cmoissar

cmoissar commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

Hey @cmoissar, do you mind if I take a stab at implementing the plasma critical density formulary as my first commit?

Of course not, have at it!

@cmoissar

cmoissar commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

@cmoissar drafts just have a note so we know they aren't ready to review. Absolutely no problem opening a PR even when rough - it allows us to easily see what you're working on and give suggestions.

I think adding some functions for LP HEDP and an example notebook that features them would be great! I would do at as 1 PR per function and then 1 PR for the notebook. If you're still interested, you should open those PRs on the main PlasmaPy package.

Thanks for your reply.
I'll (slowly) work on that after my summer break!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants