FRLG Prize Corner: Redeem multiple prizes per reset#1147
Open
kichithewolf wants to merge 4 commits intoPokemonAutomation:mainfrom
Open
FRLG Prize Corner: Redeem multiple prizes per reset#1147kichithewolf wants to merge 4 commits intoPokemonAutomation:mainfrom
kichithewolf wants to merge 4 commits intoPokemonAutomation:mainfrom
Conversation
pifopi
reviewed
Mar 29, 2026
| void PrizeCornerReset::on_config_value_changed(void* object){ | ||
| std::string error; | ||
|
|
||
| error = check_amount_redeemed((uint16_t)SLOT.current_value(), NUM_REDEEM); |
Member
There was a problem hiding this comment.
you can declare the string right here. This is usually recommended in C++ so that the variable can be const and is never uninitialized
| if (slot_num == 4 && redeem_num != 1) { //Only 1 Porygon in both FR and LG | ||
| return "Error: Cannot redeem more than 1 Porygon per reset due to coin case limit."; | ||
| } else if (slot_num == 3 && redeem_num > 2) { //2 Dratini LG or 1 Scyther FR | ||
| return "Error: Maximum redemption of 2 Dratini per reset due to coin case limit."; |
Member
There was a problem hiding this comment.
2 Dratini or 1 Scyther ? Not sure if this would be more misleading or not
| WARNING.set_visibility(ConfigOptionState::HIDDEN); | ||
| } | ||
|
|
||
| void PrizeCornerReset::on_config_value_changed(void* object){ |
Member
There was a problem hiding this comment.
Why do this early and not rely on the exteption being thrown when program start ?
Collaborator
Author
There was a problem hiding this comment.
Mostly trying to really make sure people have their setup right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New option added for multiple redemptions per reset. Requires that the user has enough coins and that there is enough room in their party.
I made an attempt to block invalid combinations of selected prize + redemptions (can't do more than one Porygon at a time), but the coin cost varies between versions, so there's one case where the block won't work: FR Scyther/LG Dratini.
The Scyther in FR costs 5500 coins while the LG Dratini costs 4600 coins, so at maximum coin count of 9999 a player on FR can only redeem Scyther once per reset, whereas the LG player can redeem Dratini twice.
Also adjusted the box values for PrizeSelectDetector to use the same positions as WhiteDialogDetector.