Add top-tail preserving MP-vs-eCPS sampling#156
Draft
MaxGhenis wants to merge 2 commits into
Draft
Conversation
MaxGhenis
force-pushed
the
codex/top-tail-preserving-compare-20260601
branch
from
be6a74b to
3a5c0db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
top_agi_preservematched sampling mode for MP-vs-eCPS comparisons--matched-top-agi-thresholdand record the threshold in comparison outputsWhy
The PR #141 PUF aggregate/support-clone artifact currently shows severe top-tail placement issues, especially cap gains and interest in high AGI bins. Uniform matched-N thinning can randomly drop rare top-tail households, so this adds a diagnostic comparison mode to separate sampling noise from true PUF aggregate synthesis problems.
This does not change production builds or the default comparison method.
Validation
uv run ruff check src/microplex_us/pipelines/performance.py src/microplex_us/pipelines/ecps_replacement_comparison.py tests/pipelines/test_performance.pyuv run --extra dev python -m pytest tests/pipelines/test_performance.py::test_sample_matched_household_ids_supports_weighted_methods tests/pipelines/test_performance.py::test_write_matched_policyengine_us_baseline_dataset_preserves_top_agi_households tests/pipelines/test_ecps_replacement_comparison.py::test_sound_ecps_replacement_comparison_satisfies_gate_contract tests/pipelines/test_ecps_replacement_comparison.py::test_ecps_replacement_comparison_module_cli_help_runs -quv run --extra dev python -m pytest tests/pipelines/test_ecps_replacement_comparison.py -q