Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/microplex_us/pipelines/us.py
Original file line number Diff line number Diff line change
Expand Up @@ -5813,10 +5813,15 @@ def add(variable: str) -> bool:
):
add(variable)

if not add("capital_gains"):
if not add("long_term_capital_gains_before_response"):
add("long_term_capital_gains")
add("short_term_capital_gains")
added_capital_gain_components = False
if add("long_term_capital_gains_before_response"):
added_capital_gain_components = True
elif add("long_term_capital_gains"):
added_capital_gain_components = True
if add("short_term_capital_gains"):
added_capital_gain_components = True
if not added_capital_gain_components:
add("capital_gains")
add("non_sch_d_capital_gains")

if not add("dividend_income") and not add("ordinary_dividend_income"):
Expand Down
57 changes: 53 additions & 4 deletions tests/pipelines/test_us.py
Original file line number Diff line number Diff line change
Expand Up @@ -4037,7 +4037,7 @@ def test_puf_support_clone_top_tail_guard_scales_investment_income(self):
guarded
)
assert rough_agi.iloc[0] == pytest.approx(78_999_999.0)
assert rough_agi.iloc[1] == pytest.approx(15_125_000.0)
assert rough_agi.iloc[1] == pytest.approx(10_125_000.0)
assert guarded["employment_income"].tolist() == [100_000.0, 125_000.0]
assert guarded["capital_gains"].iloc[0] < clone["capital_gains"].iloc[0]
assert (
Expand All @@ -4047,11 +4047,11 @@ def test_puf_support_clone_top_tail_guard_scales_investment_income(self):
assert summary["affected_rows"] == 1
assert rough_agi_variables == [
"employment_income",
"capital_gains",
"long_term_capital_gains",
"qualified_dividend_income",
]
assert summary["scale_basis_variables"] == [
"capital_gains",
"long_term_capital_gains",
"qualified_dividend_income",
]
assert "long_term_capital_gains" in summary["scaled_variables"]
Expand Down Expand Up @@ -4094,12 +4094,61 @@ def test_puf_support_clone_top_tail_guard_avoids_redundant_income_totals(self):
assert rough_agi.iloc[0] == pytest.approx(65_100_000.0)
assert rough_agi_variables == [
"employment_income",
"capital_gains",
"long_term_capital_gains",
"short_term_capital_gains",
"ordinary_dividend_income",
]
pd.testing.assert_frame_equal(guarded, clone)
assert summary["affected_rows"] == 0

def test_puf_support_clone_top_tail_guard_prefers_capital_gains_components(
self,
):
pipeline = USMicroplexPipeline(
USMicroplexBuildConfig(
synthesis_backend="seed",
puf_support_clone_enabled=True,
puf_support_clone_top_tail_rough_agi_cap=78_999_999.0,
)
)
clone = pd.DataFrame(
{
"employment_income": [105_000.0],
"capital_gains": [14_000_000.0],
"long_term_capital_gains": [95_000_000.0],
"short_term_capital_gains": [250.0],
}
)

guarded, summary = pipeline._apply_puf_support_clone_top_tail_guard(
clone,
integrated_variables=[
"capital_gains",
"long_term_capital_gains",
"short_term_capital_gains",
],
)
rough_agi, rough_agi_variables = pipeline._puf_support_clone_top_tail_rough_agi(
guarded
)

assert rough_agi.iloc[0] == pytest.approx(78_999_999.0)
assert rough_agi_variables == [
"employment_income",
"long_term_capital_gains",
"short_term_capital_gains",
]
assert guarded["capital_gains"].iloc[0] < clone["capital_gains"].iloc[0]
assert (
guarded["long_term_capital_gains"].iloc[0]
< clone["long_term_capital_gains"].iloc[0]
)
assert summary["affected_rows"] == 1
assert summary["scale_basis_variables"] == [
"long_term_capital_gains",
"short_term_capital_gains",
]

def test_puf_support_clone_top_tail_guard_scales_exported_ltcg_alias(self):
pipeline = USMicroplexPipeline(
USMicroplexBuildConfig(
Expand Down
Loading