Coalesce sparse PE input aliases by row#173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The post-#170 H5 passed export-column parity, but source alias inspection showed important PE input families were being zeroed whenever a canonical column existed sparsely. The sidecar audit showed this particularly on employment/wages, taxable interest, and dividends. This PR fixes that structural alias masking without changing calibration, robust-loss scoring, or the APG optimizer branch.
Tests
uv run --python 3.13 --extra dev python -m pytest tests/pipelines/test_us.py::TestUSMicroplexPipeline::test_augment_policyengine_person_inputs_coalesces_sparse_source_aliases_by_row tests/test_variables.py::test_normalize_dividend_columns_coalesces_sparse_total_aliases_by_rowuv run --python 3.13 --extra dev python -m pytest tests/pipelines/test_us.py::TestUSMicroplexPipeline::test_augment_policyengine_person_inputs_materializes_agi_parity_inputs tests/pipelines/test_us.py::TestUSMicroplexPipeline::test_augment_policyengine_person_inputs_coalesces_sparse_source_aliases_by_rowuv run --python 3.13 --extra dev python -m pytest tests/test_variables.pyuv run --python 3.13 ruff check src/microplex_us/pipelines/us.py src/microplex_us/variables.py tests/pipelines/test_us.py tests/test_variables.py