Allow checkpoint-only version artifact directories#198
Open
anth-volk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #179.
stage_runtime_writerthroughsave_versioned_us_microplex_artifacts()to match the existing_finalize_versioned_build_artifacts()call path.Notes on Scope
The checkpoint-only directory allowance is the direct #179 fix. While validating the full versioned-artifacts test file, current
mainalso exposed an adjacent finalization mismatch:_finalize_versioned_build_artifacts()already passedstage_runtime_writer, butsave_versioned_us_microplex_artifacts()did not accept or forward it. This PR includes that small pass-through so the live stage-runtime path remains consistent.Tests
ruff check src/microplex_us/pipelines/versioned_artifacts.py tests/pipelines/test_versioned_artifacts.pygit diff --checkPYTHONPATH=/Users/administrator/Documents/PolicyEngine/microplex-us/src PYTHONDONTWRITEBYTECODE=1 /Users/administrator/Documents/PolicyEngine/worktrees/microplex-us/fix-pe-rebuild-smoke-issues/.venv/bin/python -m pytest -q -p no:cacheprovider tests/pipelines/test_versioned_artifacts.py -k 'configured_checkpoint or unrelated_existing or unconfigured_checkpoint or existing_version_file'PYTHONPATH=/Users/administrator/Documents/PolicyEngine/microplex-us/src PYTHONDONTWRITEBYTECODE=1 /Users/administrator/Documents/PolicyEngine/worktrees/microplex-us/fix-pe-rebuild-smoke-issues/.venv/bin/python -m pytest -q -p no:cacheprovider tests/pipelines/test_artifacts.py::test_source_provider_versioned_build_initializes_live_stage_writerA full
tests/pipelines/test_versioned_artifacts.pyrun passed before the final non-directory guard was added; after the guard, the focused allocator tests above cover the changed behavior.