Address referee feedback: determinism, code cleanup, multi-seed benchmarks#1
Merged
Merged
Conversation
…lti-seed benchmarks - Fix PyTorch seed determinism in benchmark runner and DataLoaders - Add multi-seed evaluation (run_multi_seed with mean +/- SE) - Fix CI mypy path typo (src/micro/ -> src/microplex/) - Add Python 3.13 to CI matrix and classifiers - Add pydantic to core dependencies - Upload benchmark dataset to HuggingFace (nikhil-woodruff/microplex-benchmark-data) - Update build_data.py with correct HuggingFace repo ID - Re-run benchmarks with deterministic seeds - Code simplification: extract shared helpers, remove unused code, consolidate duplication Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add census2023sipp, psid2023, mullahy1986specification bib entries - Remove xu2019tvae duplicate (merged into xu2019modeling) - Fix tutorial import: micro -> microplex - Update README: accurate feature table, method list, citation year Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch.Generator())run_multi_seed()method with mean +/- SE aggregation and--n-seedsCLI flagsrc/micro/->src/microplex/), add Python 3.13 to CI matrixpydanticto core dependencies (was missing, caused import failures on 3.13)nikhil-woodruff/microplex-benchmark-data)METHOD_MAP, consolidate duplication in benchmark.py, run_benchmark.py, paper_results.pyTest plan
🤖 Generated with Claude Code