Align calculator header with main website header#1066
Merged
Conversation
The calculator-app shell (/us/reports etc.) still rendered through StandardLayout → HomeHeader, which kept the pre-#1059 design (click-open dropdowns, no per-item underline, missing Model/Python/Events). Update NavItem to mirror the website Header (hover-open, underline with active detection, nested children), expand the navItems in HomeHeader to match, and teach MobileMenu to render nested children. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
These files were ported to website/src/components/Header.tsx, but the calculator-app still renders the legacy HomeHeader via StandardLayout, so they have to stay editable in app/. Drop the matching entries from the PR guard and document the situation in CLAUDE.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/us/reports) still rendered throughStandardLayout→HomeHeader, which kept the pre-Header: hover-open dropdowns, per-item underline, Model dropdown #1059 design: click-open dropdowns, no per-item underline, and missing the new Model/Python/Events nav items.website/src/components/Header.tsx) added in Header: hover-open dropdowns, per-item underline, Model dropdown #1059.Changes
app/src/components/homeHeader/NavItem.tsx— hover-open dropdowns (100ms open / 200ms close), per-item underline with active-page detection viauseAppPathname, nestedchildrensupport, Apple-style dropdown panel matching the website.app/src/components/shared/HomeHeader.tsx— add Model dropdown (Rules / Data / Behavioral responses with sub-items), Python nav item, Events under About.app/src/components/homeHeader/MobileMenu.tsx— render nestedchildrenitems indented under their parent.changelog_entry.yaml— entry added.Test plan
make typecheck✅ (verified locally)cd calculator-app && bun run typecheck✅ (verified locally)cd app && bun run lint✅ (verified locally)Model,API,Python) navigate via<a>(full page load) to the website zone.🤖 Generated with Claude Code