Skip to content

[codex] Improve SPM calculator launch flow #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MaxGhenis wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[codex] Improve SPM calculator launch flow #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8575ef3
Improve SPM calculator launch flow
MaxGhenis Apr 12, 2026
97b4865
Fix launch PR page test expectations
MaxGhenis Apr 12, 2026
c8c2a44
[codex] Fix audited accessibility issues on website and calculator (#…
MaxGhenis Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions app/src/components/IngredientReadView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ interface IngredientReadViewProps {
title: string;
subtitle?: string;
buttonLabel?: string;
emptyState?: React.ReactNode;
onBuild?: () => void;
isLoading: boolean;
isError: boolean;
Expand All @@ -37,6 +38,7 @@ export default function IngredientReadView({
title,
subtitle,
buttonLabel,
emptyState,
onBuild,
isLoading,
isError,
Expand Down Expand Up @@ -81,21 +83,6 @@ export default function IngredientReadView({
</div>
</div>

{/* Title Section */}
<div style={{ marginBottom: spacing.xl }}>
<Title
order={2}
style={{
fontSize: typography.fontSize.lg,
fontWeight: typography.fontWeight.semibold,
color: colors.text.title,
marginBottom: spacing.lg,
}}
>
{title}
</Title>
</div>

{/* Content Section */}
<div
style={{
Expand All @@ -122,7 +109,7 @@ export default function IngredientReadView({
<>
{data.length === 0 ? (
<div style={{ padding: spacing['3xl'] }}>
<EmptyState ingredient={ingredient} />
{emptyState || <EmptyState ingredient={ingredient} />}
</div>
) : (
<Table>
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/StandardLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function StandardLayout({ children }: StandardLayoutProps) {
>
<Sidebar />
</nav>
<main className="tw:flex-1 tw:min-w-0 tw:max-w-[calc(100vw-300px)] tw:overflow-y-auto tw:overflow-x-hidden tw:p-[24px] tw:bg-gray-50">
<main className="tw:flex-1 tw:min-w-0 tw:max-w-full tw:overflow-y-auto tw:overflow-x-hidden tw:bg-gray-50 tw:p-[24px] sm:tw:max-w-[calc(100vw-300px)]">
{children}
</main>
</div>
Expand Down
Loading
Loading