Fix ruff formatting in validation notebook#1743
Merged
Merged
Conversation
#1696 inserted warnings-suppression lines that were not ruff-formatted; the docs-only path filter skipped the full Lint on that merge, so the violation only surfaced when a later code PR triggered a repo-wide ruff format --check on main. Add the blank line ruff wants. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import warnings/warnings.filterwarnings("ignore")at the top of the validation notebook's code cell, but the lines weren't ruff-formatted (ruff wants a blank line after the import).ruff format --check, turning the Lint job red on main.ruff formatto the notebook to restore a green main.Test plan
ruff format --check docs/book/validation/validation.ipynbpasses locally.🤖 Generated with Claude Code