Skip to content

Remove US-data Medicaid cost allocator#1152

Merged
MaxGhenis merged 2 commits into
mainfrom
codex/remove-us-data-medicaid-cost-allocator
May 29, 2026
Merged

Remove US-data Medicaid cost allocator#1152
MaxGhenis merged 2 commits into
mainfrom
codex/remove-us-data-medicaid-cost-allocator

Conversation

@daphnehanse11
Copy link
Copy Markdown
Collaborator

@daphnehanse11 daphnehanse11 commented May 28, 2026

Summary

Removes the duplicate Medicaid conditional-cost allocator from policyengine-us-data so Medicaid cost logic can live in PolicyEngine US.

  • removes the CPS and Extended CPS Medicaid cost generation hooks
  • deletes the us-data SLCSP allocator and its tests
  • removes the local H5 Medicaid cost postprocessor and associated tests
  • regenerates pipeline docs after removing the postprocessor node
  • pins policyengine-us==1.715.2, the released PE-US version containing the formula-backed medicaid_cost_if_enrolled variable
  • adds a dependency contract test so us-data fails fast if the pinned PE-US package does not provide the Medicaid cost formula

Depends on PolicyEngine/policyengine-us#8538, which has been merged and released as policyengine-us==1.715.2.

Tests

  • uv run ruff format tests/unit/test_policyengine_us_dependency_contract.py --check
  • uv run ruff check tests/unit/test_policyengine_us_dependency_contract.py
  • env -u UV_FROZEN uv lock --check
  • uv run pytest tests/unit/test_policyengine_us_dependency_contract.py tests/unit/build_outputs/test_us_augmentations.py tests/unit/calibration/test_publish_local_area.py tests/unit/test_pipeline_docs_extractor.py

@daphnehanse11 daphnehanse11 force-pushed the codex/remove-us-data-medicaid-cost-allocator branch from 23e7d3d to 547987d Compare May 28, 2026 19:00
@MaxGhenis MaxGhenis marked this pull request as ready for review May 29, 2026 02:52
@MaxGhenis
Copy link
Copy Markdown
Contributor

Fixed the release sequencing issue from review.

  • Merged Move Medicaid cost allocation into PE-US policyengine-us#8538 and waited for policyengine-us==1.715.2 to publish.
  • Updated us-data to pin policyengine-us==1.715.2 and refreshed uv.lock.
  • Added a dependency contract test asserting medicaid_cost_if_enrolled is formula-backed in the pinned PE-US package.

Local verification:

  • uv run pytest tests/unit/test_policyengine_us_dependency_contract.py tests/unit/build_outputs/test_us_augmentations.py tests/unit/calibration/test_publish_local_area.py tests/unit/test_pipeline_docs_extractor.py
  • uv run ruff format tests/unit/test_policyengine_us_dependency_contract.py --check
  • uv run ruff check tests/unit/test_policyengine_us_dependency_contract.py
  • env -u UV_FROZEN uv lock --check

Copy link
Copy Markdown
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Medicaid cost allocator removal after PE-US 1.715.2 release. CI is green and the dependency contract now guards the formula-backed medicaid_cost_if_enrolled requirement.

@MaxGhenis MaxGhenis merged commit c40ea50 into main May 29, 2026
14 checks passed
@MaxGhenis MaxGhenis deleted the codex/remove-us-data-medicaid-cost-allocator branch May 29, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants