Skip to content

Add country package version to economy comparisons#126

Merged
anth-volk merged 6 commits into
mainfrom
feat/api-version-in-output
May 13, 2025
Merged

Add country package version to economy comparisons#126
anth-volk merged 6 commits into
mainfrom
feat/api-version-in-output

Conversation

@anth-volk
Copy link
Copy Markdown
Contributor

@anth-volk anth-volk commented May 13, 2025

Fixes #125.

What Changed

  • Added a utility function to fetch the version of a given package in an environment
  • Added a function to fetch the version of a policyengine country package based upon country ID
  • Updated EconomyComparison schema to include country_package_version key
  • Updated calculate_economy_comparison() to provide the country package version key as part of its returned EconomyComparison dict
  • Added tests for utility functions

Why This Change

  • Allows for passing of country package version value to workflow run output, simplifying downstream comparison of this and v1 workflow country package version

mikesmit
mikesmit reviewed May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mikesmit mikesmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One opinionated comment, otherwise nitts or questions.

Comment thread policyengine/constants.py Outdated
Comment thread policyengine/utils/versioning.py Outdated
Comment thread tests/utils/test_versioning.py Outdated
Comment thread policyengine/outputs/macro/comparison/calculate_economy_comparison.py
@anth-volk
Copy link
Copy Markdown
Contributor Author

anth-volk commented May 13, 2025

Update: tests fail due to a typo in the schema definition

@anth-volk anth-volk marked this pull request as draft May 13, 2025 17:31
@anth-volk
Copy link
Copy Markdown
Contributor Author

anth-volk commented May 13, 2025

Modifying based on review. Switching to draft until complete.

mikesmit
mikesmit reviewed May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mikesmit mikesmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One opinionated comment, otherwise nitts or questions.

Comment thread policyengine/constants.py Outdated
@anth-volk anth-volk marked this pull request as ready for review May 13, 2025 20:38
@anth-volk anth-volk merged commit 8d821cb into main May 13, 2025
3 checks passed
@anth-volk anth-volk deleted the feat/api-version-in-output branch May 13, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikesmit mikesmit mikesmit left review comments

@nikhilwoodruff nikhilwoodruff Awaiting requested review from nikhilwoodruff

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add country package version to economy output runs

2 participants

@anth-volk @mikesmit