Open
Conversation
hamshkhawar
requested review from
NHotaling and
Nicholas-Schaub
as code owners
hamshkhawar
force-pushed
the
update/feature_subsetting
branch
from
d155ca1 to
d384b72
Compare
bengtl
reviewed
Jan 26, 2024
Member
bengtl
left a comment
bengtl
left a comment
There was a problem hiding this comment.
Some minor changes, please see comments in files.
| ## Options | ||
|
|
||
| This plugin takes one input argument and one output argument: | ||
| This plugin takes twelve input arguments and one output argument: |
| 4. `imageFeature` - Tabular data featuring image filenames | ||
| 5. `tabularFeature` - Tabular feature that will be used to filter images | ||
| 6. `groupVar` - This is a mandatory input across which to subset data. This can take either 1 or 2 variables as input and if 2 variables are provided then the second variable will be treated as the minor grouping variable. In our example, if the `z` is provided as input, then within a subcollection, the mean of the feature value will be taken for all images with the same z. Then the z positions will be filtered out based on the input of `percentile` and `removeDirection` variables. Now if `z,c` are provided as input, then 'c' will be treated as the minor grouping variable which means that the mean will be taken for all images with the same z for each channel. Also, the plugin will ensures that the same values of z positions are filtered out across c. | ||
| 7. `percentile` and `removeDirection` - These two variables denote the critieria with which images are filtered. For example, if percentile is `0.1` and removeDirection is set to `Below` then images with feature value below the 10th percentile will be removed. On the other hand, if removeDirection is set to above then all images with feature value greater than the 10th pecentile will be removed. This enables data subsetting from both `brighfield` and `darkfield` microscopy images. |
Member
There was a problem hiding this comment.
Suggested change
| 7. `percentile` and `removeDirection` - These two variables denote the critieria with which images are filtered. For example, if percentile is `0.1` and removeDirection is set to `Below` then images with feature value below the 10th percentile will be removed. On the other hand, if removeDirection is set to above then all images with feature value greater than the 10th pecentile will be removed. This enables data subsetting from both `brighfield` and `darkfield` microscopy images. | |
| 7. `percentile` and `removeDirection` - These two variables denote the critieria with which images are filtered. For example, if percentile is `0.1` and removeDirection is set to `Below` then images with feature value below the 10th percentile will be removed. On the other hand, if removeDirection is set to above then all images with feature value greater than the 10th pecentile will be removed. This enables data subsetting from both `brightfield` and `darkfield` microscopy images. |
|
|
||
| CHUNK_SIZE = 10000 | ||
|
|
||
| logger = logging.getLogger(__name__) |
Member
There was a problem hiding this comment.
It seems the logger is initiated twice? It is already initiated in the main.py
hamshkhawar
force-pushed
the
update/feature_subsetting
branch
from
1febf79 to
0e82f4b
Compare
Nicholas-Schaub
requested changes
Aug 6, 2024
Contributor
Nicholas-Schaub
left a comment
Nicholas-Schaub
left a comment
There was a problem hiding this comment.
Versions do not match across files (VERSION, Readme, etc.)
* fix merge conflicts * fix apply manifest * fix apply manifest * remove file * updated hdbscan-clustering-plugin * fix bug in tests * fixed random generation of floats * fixed docker file and shell script for running docker * fixed docker files * renamed plugin and fixed merged conflicts * fixed docker files
Member
Author
I fixed it and add CLT and ict.yaml file for this plugin |
bengtl
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is updated to new plugin standards