Updated three tools to use numpy 2.0#564
Open
nishaq503 wants to merge 1 commit intoPolusAI:masterfrom
Open
Conversation
nishaq503
requested review from
NHotaling,
Nicholas-Schaub and
hsidky
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the following tools:
Since numpy changed how type promotion works for operations between arrays of different types, I have explicitly used type casts where it makes sense to do so.
A outstanding issue is that numpy is already up to version 2.1 which requires python 3.10 but all polus tools are still on python 3.9.