Revert "Fix verifier not verifying"

[hczphn]

Reverts #318
The mpi verifier still fails.

[gemini-code-assist]

Summary of Changes

Hello @hczphn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a full revert of a previous attempt to fix a verifier issue, specifically #318. The decision to revert was made because the prior changes did not successfully resolve the problem, with the MPI verifier continuing to fail. The primary impact is the removal of a dedicated public input binding and checking mechanism, streamlining the verification process by directly incorporating public input elements into the transcript generation.

Highlights

• Revert Previous Fix: Reverted the changes introduced in Fix verifier not verifying #318, which aimed to fix a verifier issue, as the MPI verifier still fails.
• Removed Helper Function: Eliminated the bind_and_check_public_inputs helper function from the Verifier implementation.
• Direct Public Input Binding: Modified the verify and verify_with_proving_time_mpi_size methods to directly append public input elements to the Fiat-Shamir transcript, replacing the call to the now-removed helper function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• gkr/src/verifier/snark.rs
  • Removed the bind_and_check_public_inputs method.
  • Updated the verify method to directly append public inputs to the transcript.
  • Updated the verify_with_proving_time_mpi_size method to directly append public inputs to the transcript.
  • Removed an unnecessary empty line in the pre_gkr function.
  • Added an empty line after the impl block for Verifier.

Activity

• The author, hczphn, initiated this pull request to revert a previous change (Fix verifier not verifying #318) because the MPI verifier issue persisted.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts a previous change that attempted to fix an issue with the verifier but introduced new problems, as noted in the pull request description. The reverted change introduced a bind_and_check_public_inputs function to read and verify public inputs from the proof stream. This logic was likely flawed, causing verifier failures. This revert correctly removes this logic and restores the previous, simpler behavior of binding the public inputs directly to the transcript. This is a standard and safe approach. The changes are applied consistently in both verify and par_verify functions. This revert is a good step towards stabilizing the verifier.