feat: add auto-pagination iterators for list endpoints#7
Open
harley-poly wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 44a5ccd. Configure here.
mustafa-poly
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary
adds
iterate()async generators that transparently walk all pages so callers no longer hand-roll cursor/offset logic:events.iterate(),markets.iterate(),series.iterate()(page until a short page is returned).portfolio.iterateActivities()(follownextCursoruntileofor an empty cursor).src/pagination.ts(paginateOffset/paginateCursor).positions are intentionally not iterated (the endpoint returns the full set in one response).
test plan
pnpm lint(biome)pnpm typecheck/pnpm buildpnpm test(135 passed; newtests/pagination.test.tscovers offset paging until short/empty page and cursor paging until eof/no-next-cursor)Note
Low Risk
Additive client-side helpers and new optional APIs; existing
list/activitiescalls are unchanged, with tests covering termination edge cases.Overview
Adds lazy auto-pagination so callers can stream full list results without manual
offset/cursorloops.New shared helpers in
src/pagination.ts:paginateOffset(stops on a short or empty page; clamps non-positive page size) andpaginateCursor(followsnextCursoruntileofor missing cursor).events,markets, andseriesgainiterate(params?, pageSize?);portfoliogains authenticatediterateActivities(params?). README documentsfor awaitusage.tests/pagination.test.tscovers multi-page offset iteration, empty-page stop, and cursor/eofbehavior.Reviewed by Cursor Bugbot for commit fa162c6. Bugbot is set up for automated code reviews on this repo. Configure here.