test: cover sync SecureClient market order placement#140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #136
Verification
Note
Low Risk
Test-only changes; the new metered test can place real orders when enabled but does not modify production SDK behavior.
Overview
Adds shared
deposit_wallet_private_keyanddeposit_wallet_addressfixtures in integrationconftest, and wiresdeposit_wallet_clientthrough them instead of reading env vars inline.Adds a metered sync test
test_sync_secure_client_create_places_market_orderthat usesSecureClient.create(...)as a context manager, lists positions, and places a live FAK market order (sell existing Yes inventory or buy minimum size), asserting anAcceptedOrderwith an expected status—parallel to the existing async market-order coverage.Reviewed by Cursor Bugbot for commit b66dd6f. Bugbot is set up for automated code reviews on this repo. Configure here.