test(clob): avoid full-position market order cleanup#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Live metered tests were not run locally.
Note
Low Risk
Changes are limited to integration test behavior and reduce live-test side effects; no production trading or client logic is modified.
Overview
Metered CLOB market-order integration tests no longer call
list_positionsor sell an entire reported position before exercising placement.Both async and sync tests now always place a minimum-size FAK buy, assert an
AcceptedOrder, and only best-effort sellresponse.taking_amountwhen it is greater than zero (errors suppressed). ThePositionimport and_find_owned_token_positionhelper are removed.Reviewed by Cursor Bugbot for commit 2803434. Bugbot is set up for automated code reviews on this repo. Configure here.