fix(client): update auto-redeem operator#147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Medium Risk
Swapping the production auto-redeem operator changes which on-chain contract receives trading approvals; a wrong address would break auto-redeem until users re-approve, and the re-enabled live test can submit real relayer transactions when metered credentials are present.
Overview
Updates production
auto_redeem_operatorto the Protocol V2 auto-redeemer contract (0xa120…00af), replacing the previous operator address. That value is whatsetup_trading_approvalsuses when granting ERC-1155setApprovalForAllto the auto-redeem path (conditional tokens and position manager), so wallets that run setup after this change will approve the new operator.The live
test_setup_trading_approvals_liveintegration test is no longer unconditionally skipped: it still runs only under the metered gate, but now buildsAsyncSecureClientfrom sharedbuilder_api_key/ deposit-wallet fixtures instead of_secure_client(require_env), and documents that it may submit missing trading approvals on the configured wallet.Reviewed by Cursor Bugbot for commit 5f7d828. Bugbot is set up for automated code reviews on this repo. Configure here.