Fix app exiting after macos gui exits #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs here specify that after a
terminatecall the process stops entirely, and since the MacOS gui returnstrueherePiton/apphost/src/ui/gui/macos/progress_dialog.rs
Line 129 in 52679d3
the app simply stops entirely after the
window.close()call. This PR fixes this, changing the above tofalseand callingstopright after the window is closed. This way theapp.run()call stops blocking and the program can continue as normal. The call tostophad to be done manually since Cacao does not implement such functionality, and after it I also encountered some buggy behavior relating to aNSAutoReleasePool. See comments for the details.There probably is a better way to have
appnotdropits pool, I'm widely open to suggestions.Some of the copied code add tons of warnings to the build process (such as the
msg_sendmacros), I do not know how fixable is this, in case it is, since it seems an issue onobjc's side.I do not know why this ever worked, but all MacOS users got affected by this issue with the .NET 8 migration of Everest.