fix: use external openai NotGiven/Omit types for compatibility #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using Portkey with libraries like pydantic-ai that pass
NOT_GIVENvalues from the standard openai package, users encounter:This happens because Portkey's vendored OpenAI SDK defines its own
NotGivenclass, which is a different class from the standard openai'sNotGiven. When pydantic-ai passes values using the standard openai'sNOT_GIVEN, the vendored code doesn't recognize them asNotGiveninstances.Solution
Instead of defining duplicate
NotGivenandOmitclasses in the vendored code, we now:This ensures that when libraries like pydantic-ai pass
NOT_GIVENvalues from the standard openai package, Portkey's vendored SDK recognizes them because they're the exact same class.Testing