Skip to content

chore: Update notify-approval-needed.yml#56

Merged
marandaneto merged 1 commit into
mainfrom
marandaneto-patch-1
Jun 23, 2026
Merged

chore: Update notify-approval-needed.yml#56
marandaneto merged 1 commit into
mainfrom
marandaneto-patch-1

Conversation

@marandaneto

@marandaneto marandaneto commented Jun 23, 2026

Copy link
Copy Markdown
Member

so its less noisy for folks and we own the release process anyway

@marandaneto marandaneto requested a review from a team as a code owner June 23, 2026 10:56
@marandaneto marandaneto requested a review from a team June 23, 2026 10:56
@marandaneto marandaneto changed the title Update notify-approval-needed.yml chore: Update notify-approval-needed.yml Jun 23, 2026
@marandaneto marandaneto enabled auto-merge (squash) June 23, 2026 10:57
ioannisj
ioannisj approved these changes Jun 23, 2026
View reviewed changes

@ioannisj ioannisj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ioannisj

ioannisj commented Jun 23, 2026

Copy link
Copy Markdown

Actually, this means that support-hero-client-libraries will have to manually ping for their own approvals. Maybe it's better to notify the whole team instead?

@marandaneto

marandaneto commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Actually, this means that support-hero-client-libraries will have to manually ping for their own approvals. Maybe it's better to notify the whole team instead?

this is a fallback from slack_user_group_id
its already @support-hero-client-libraries so same as is now

@marandaneto marandaneto merged commit cb0979b into main Jun 23, 2026
12 of 13 checks passed
@marandaneto marandaneto deleted the marandaneto-patch-1 branch June 23, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piccirello Piccirello Piccirello approved these changes
@ioannisj ioannisj ioannisj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marandaneto @ioannisj @Piccirello