Skip to content

feat: codex 5.4 default and pass to model #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k11kirky wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

feat: codex 5.4 default and pass to model #1479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/code/src/main/services/agent/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { getEffortOptions } from "@posthog/agent/adapters/claude/session/models"
import { Agent } from "@posthog/agent/agent";
import { getAvailableModes } from "@posthog/agent/execution-mode";
import {
DEFAULT_CODEX_MODEL,
DEFAULT_GATEWAY_MODEL,
fetchGatewayModels,
formatGatewayModelName,
Expand Down Expand Up @@ -554,6 +555,7 @@ When creating pull requests, add the following footer at the end of the PR descr
adapter,
gatewayUrl: proxyUrl,
codexBinaryPath: adapter === "codex" ? getCodexBinaryPath() : undefined,
model,
processCallbacks: {
onProcessSpawned: (info) => {
this.processTracking.register(
Expand Down Expand Up @@ -1622,7 +1624,9 @@ For git operations while detached:

const defaultModel =
adapter === "codex"
? (modelOptions[0]?.value ?? "")
? (modelOptions.find((o) => o.value === DEFAULT_CODEX_MODEL)?.value ??
modelOptions[0]?.value ??
"")
: DEFAULT_GATEWAY_MODEL;

const resolvedModelId = modelOptions.some((o) => o.value === defaultModel)
Expand Down
5 changes: 4 additions & 1 deletion packages/agent/src/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
} from "./adapters/acp-connection";
import {
BLOCKED_MODELS,
DEFAULT_CODEX_MODEL,
DEFAULT_GATEWAY_MODEL,
fetchModelsList,
} from "./gateway-models";
Expand Down Expand Up @@ -104,7 +105,9 @@ export class Agent {
}

if (!sanitizedModel || !allowedModelIds?.has(sanitizedModel)) {
sanitizedModel = codexModelIds[0];
sanitizedModel = codexModelIds.includes(DEFAULT_CODEX_MODEL)
? DEFAULT_CODEX_MODEL
: codexModelIds[0];
}
}
if (!sanitizedModel && options.adapter !== "codex") {
Expand Down
2 changes: 2 additions & 0 deletions packages/agent/src/gateway-models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ export interface FetchGatewayModelsOptions {

export const DEFAULT_GATEWAY_MODEL = "claude-opus-4-6";

export const DEFAULT_CODEX_MODEL = "gpt-5.4";

export const BLOCKED_MODELS = new Set(["gpt-5-mini", "openai/gpt-5-mini"]);

type ModelsListResponse =
Expand Down
Loading