feat: update codex adapter and migrate to base acp prxy for agent#1480
Open
k11kirky wants to merge 1 commit into04-03-feat_codex_5.4_default_and_pass_to_modelfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 3, 2026
charlesvien
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TLDR: upgraded codex acp bin and started moving over to similar proxy agent as claude agent sdk
Problem
The Codex adapter was using a raw stream transformation approach that made it difficult to implement PostHog-specific features like session tracking, usage accumulation, and proper session resume/fork capabilities. This approach also lacked proper interception points for ACP protocol messages.
Changes
Upgraded codex-acp binary from v0.9.5 to v0.11.1 to get the latest features and bug fixes.
Replaced raw stream transformation with proper ACP Agent implementation:
CodexAcpAgentclass that implements the ACP Agent interfaceCodexClientto handle delegation between codex-acp subprocess and upstream PostHog Code clientCodexSessionStateandCodexSettingsManagerEnhanced PostHog integration:
_posthog/sdk_sessionnotification emission for session tracking_posthog/usage_updatenotificationsImproved architecture: