Skip to content

chore: run required checks on docs-only PRs#235

Merged
dustinbyrne merged 4 commits into
mainfrom
chore/run-required-checks-on-markdown-prs-20260616
Jun 17, 2026
Merged

chore: run required checks on docs-only PRs#235
dustinbyrne merged 4 commits into
mainfrom
chore/run-required-checks-on-markdown-prs-20260616

Conversation

@dustinbyrne

@dustinbyrne dustinbyrne commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Problem

Required checks can remain permanently pending on docs-only PRs when the workflow that reports the required check is skipped by a PR path filter.

Changes

  • Keep required-check workflows running for PRs so required status contexts are always reported.
  • Reuse the shared markdown-only detector from PostHog/.github pinned to ec25337d9fae0100622cbfea1bd5bd88284ac10b.
  • Scope pull-requests: read to only the detector job.
  • For PRs where every changed file ends in .md, each required job runs a neutral completion step and bypasses the build/test/lint work.
  • For any PR with non-.md changes, the normal CI steps still run.

How did you test this code?

  • Reviewed the workflow diff.
  • Ran git diff --check.
  • Parsed the edited workflow YAML locally.
  • Verified the copied detector implementation was removed and the shared workflow reference is pinned to the merged .github commit.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Pi was used to apply this workflow change after markdown-only AI policy PRs exposed required checks that did not report. One subagent inspected each affected repo before implementation so the required job names and workflow structure stayed repo-specific. The common detector was then factored into PostHog/.github and referenced from this repo after that shared workflow merged.

@dustinbyrne dustinbyrne requested a review from a team as a code owner June 16, 2026 15:02
@dustinbyrne dustinbyrne self-assigned this Jun 16, 2026
@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "chore: run required checks on docs-only ..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

posthog-dotnet Compliance Report

Date: 2026-06-16 17:55:22 UTC
Duration: 623ms

⚠️ Some Tests Failed

2/16 tests passed, 14 failed


Feature_Flags Tests

⚠️ 2/16 tests passed, 14 failed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 42ms
Request Payload.Flags Request Uses V2 Query Param 22ms
Request Payload.Flags Request Hits Flags Path Not Decide 5ms
Request Payload.Flags Request Omits Authorization Header 5ms
Request Payload.Token In Flags Body Matches Init 5ms
Request Payload.Groups Round Trip 5ms
Request Payload.Groups Default To Empty Object 5ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It 5ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 4ms
Request Payload.Disable Geoip Omitted Defaults To False 5ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 5ms
Request Lifecycle.No Flags Request On Init Alone 3ms
Request Lifecycle.No Flags Request On Normal Capture 182ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 7ms
Request Lifecycle.Mock Response Value Is Returned To Caller 5ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 5ms

Failures

request_payload.request_with_person_properties_device_id

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flags_request_uses_v2_query_param

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flags_request_hits_flags_path_not_decide

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flags_request_omits_authorization_header

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.token_in_flags_body_matches_init

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.groups_round_trip

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.groups_default_to_empty_object

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.person_properties_distinct_id_auto_populated_when_caller_omits_it

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.disable_geoip_false_propagates_as_geoip_disable_false

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.disable_geoip_omitted_defaults_to_false

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_payload.flag_keys_to_evaluate_contains_only_requested_key

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_lifecycle.two_flag_calls_produce_two_remote_requests

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

request_lifecycle.mock_response_value_is_returned_to_caller

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

side_effect_events.get_feature_flag_captures_feature_flag_called_event

404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'

@dustinbyrne

Copy link
Copy Markdown
Contributor Author

will update to use PostHog/.github#54

@dustinbyrne dustinbyrne merged commit a9c709f into main Jun 17, 2026
21 checks passed
@dustinbyrne dustinbyrne deleted the chore/run-required-checks-on-markdown-prs-20260616 branch June 17, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants