Skip to content

Conversation

@adboio
Copy link
Contributor

@adboio adboio commented Jan 22, 2026

💡 Motivation and Context

need to support thumbs up/down to match other SDKs

💚 How did you test it?

Screenshot 2026-01-22 at 2.56.39 PM.png

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

Copy link
Contributor Author

adboio commented Jan 22, 2026

@adboio adboio changed the base branch from kyle/improve-survey-color-consistency to graphite-base/257 January 22, 2026 23:04
@adboio adboio force-pushed the graphite-base/257 branch from d529a78 to c739d2f Compare January 22, 2026 23:05
@adboio adboio force-pushed the 01-22-chore_surveys_enable_thumb_survey_display branch from 2dfd4c6 to 3a513f6 Compare January 22, 2026 23:05
@adboio adboio changed the base branch from graphite-base/257 to kyle/improve-survey-color-consistency January 22, 2026 23:05
@adboio adboio requested a review from a team January 22, 2026 23:19
@adboio adboio marked this pull request as ready for review January 22, 2026 23:19
@adboio adboio force-pushed the kyle/improve-survey-color-consistency branch from c739d2f to 1f5f2cf Compare January 22, 2026 23:30
@adboio adboio force-pushed the 01-22-chore_surveys_enable_thumb_survey_display branch from 3a513f6 to 0252499 Compare January 22, 2026 23:30
Copy link
Collaborator

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Something that just occurred to me, is the order of the thumbs up/down icons (LTR) intentional? (I see iOS PR does the same, so probably yes) I'm pretty sure I've seen thumbs up on the right in other survey tools, and it also goes against the order of our emoji rating.

Copy link
Collaborator

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw there are some build error and CI is not happy, let's address these first

@adboio adboio force-pushed the 01-22-chore_surveys_enable_thumb_survey_display branch from 0252499 to 64933a8 Compare January 23, 2026 18:01
@adboio adboio force-pushed the kyle/improve-survey-color-consistency branch 2 times, most recently from ab56ace to 5a48b48 Compare January 23, 2026 22:26
@adboio adboio force-pushed the 01-22-chore_surveys_enable_thumb_survey_display branch from 64933a8 to ad239f8 Compare January 23, 2026 22:26
@adboio adboio force-pushed the kyle/improve-survey-color-consistency branch from 5a48b48 to e8a0962 Compare January 23, 2026 22:28
@adboio adboio force-pushed the 01-22-chore_surveys_enable_thumb_survey_display branch from ad239f8 to 67c283f Compare January 23, 2026 22:28
Copy link
Contributor Author

adboio commented Jan 29, 2026

@ioannisj it does go against the rest of the emoji rating ordering, my instinct was just that thumbs-up made more sense on the left 😆

would like to keep as-is for now because everything else uses this ordering, but if we want to change it we can later -- or maybe we shift to that more generic 'list of emojis / numbers' pattern we discussed and then it doesn't matter

@adboio adboio force-pushed the 01-22-chore_surveys_enable_thumb_survey_display branch from 67c283f to 6a0ee8f Compare January 30, 2026 23:05
@adboio adboio force-pushed the kyle/improve-survey-color-consistency branch 2 times, most recently from eb47aad to 9fc6669 Compare January 30, 2026 23:06
@adboio adboio force-pushed the 01-22-chore_surveys_enable_thumb_survey_display branch from 6a0ee8f to 585502c Compare January 30, 2026 23:06
Base automatically changed from kyle/improve-survey-color-consistency to main February 2, 2026 07:33
@ioannisj
Copy link
Collaborator

ioannisj commented Feb 2, 2026

@adboio 3.30.0 is out so CI is probably now unblocked here

@adboio
Copy link
Contributor Author

adboio commented Feb 2, 2026

yep thanks @ioannisj ! will re-run CI and try to merge + get both flutter changes released in the morning

Copy link
Collaborator

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Stamping here to unblock you then

@marandaneto
Copy link
Member

dart format --set-exit-if-changed ./
Formatted lib/src/surveys/widgets/rating_icons.dart
Formatted lib/src/surveys/widgets/rating_question.dart

and some pr conflicts to fix

@adboio adboio force-pushed the 01-22-chore_surveys_enable_thumb_survey_display branch from 585502c to a0ccac3 Compare February 2, 2026 16:43
@adboio adboio force-pushed the 01-22-chore_surveys_enable_thumb_survey_display branch from a0ccac3 to b5f27cc Compare February 2, 2026 16:46
@adboio adboio merged commit 16031dd into main Feb 2, 2026
17 checks passed
@adboio adboio deleted the 01-22-chore_surveys_enable_thumb_survey_display branch February 2, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants