Skip to content

perf: Optimize mask widget rect collection to O(N) #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 4 commits into from
Jan 29, 2026
Merged

perf: Optimize mask widget rect collection to O(N) #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
311429a
perf: Optimize mask widget rect collection to O(N)
jeremiahseun Jan 27, 2026
b8d65b1
Deleted test file and updated changelog
jeremiahseun Jan 28, 2026
706883d
Apply suggestion from @marandaneto
marandaneto Jan 28, 2026
42e6c15
Merge branch 'main' into perf/optimize-element-data-rect-check
marandaneto Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## Next


- perf: Optimize mask widget rect collection to O(N) ([#269](https://github.com/PostHog/posthog-flutter/pull/269))

# 5.12.0

- feat: flutter error tracking support for web ([#243](https://github.com/PostHog/posthog-flutter/pull/243))
Expand Down
14 changes: 7 additions & 7 deletions lib/src/replay/element_parsers/element_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ class ElementData {
}

List<Rect> extractMaskWidgetRects() {
final rects = <Rect>[];
final rects = <Rect>{};
_collectMaskWidgetRects(this, rects);
return rects;
return rects.toList();
}

List<ElementData> extractRects({bool isRoot = true}) {
Expand All @@ -47,22 +47,22 @@ class ElementData {
return rects;
}

void _collectMaskWidgetRects(ElementData element, List<Rect> rectList) {
if (!rectList.contains(element.rect)) {
void _collectMaskWidgetRects(ElementData element, Set<Rect> rectSet) {
if (!rectSet.contains(element.rect)) {
if (element.widget is PostHogMaskWidget) {
rectList.add(element.rect);
rectSet.add(element.rect);
} else if (element.widget is TextField) {
final textField = element.widget as TextField;
if (textField.obscureText) {
rectList.add(element.rect);
rectSet.add(element.rect);
}
}
}

final children = element.children;
if (children != null && children.isNotEmpty) {
for (var child in children) {
_collectMaskWidgetRects(child, rectList);
_collectMaskWidgetRects(child, rectSet);
}
}
}
Expand Down
Loading