fix: @posthog/nextjs-config keeps scss files sourcemap when delete-after enabled#3949
Closed
github-actions[bot] wants to merge 4 commits into
Closed
fix: @posthog/nextjs-config keeps scss files sourcemap when delete-after enabled#3949github-actions[bot] wants to merge 4 commits into
scss files sourcemap when delete-after enabled#3949github-actions[bot] wants to merge 4 commits into
Conversation
…elete-after enabled
8 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Reviews (1): Last reviewed commit: "Fix #2383: @posthog/nextjs-config keeps ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
|
@posthog-watcher address review |
marandaneto
changed the title
scss files sourcemap when delete-after enabledscss files sourcemap when delete-after enabled
marandaneto
changed the title
scss files sourcemap when delete-after enabledscss files sourcemap when delete-after enabled
Contributor
Author
Contributor
Author
|
Size Change: +1 kB (+0.01%) Total Size: 16.9 MB
ℹ️ View Unchanged
|
Member
|
@PostHog/team-error-tracking does this make sense? |
Contributor
|
@marandaneto it's a bit weird since we don't really do anything with the CSS so there's no "reason" to process/upload them. it might actually "work" as a side effect (since it deletes them after), but it'll add to the upload without being too useful, we should figure out how to just delete them if deleteAfterUpload is set IMO |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted) — or — Fully autonomous
Fixes #2383
Generated by posthog-watcher-action using pi.
Summary
Next.js SCSS/CSS sourcemaps under .next/static/css were reportedly left behind when delete-after was enabled because only uploaded sourcemaps were deleted.
Triage rationale
A new small PR does not appear appropriate without a fresh reproduction because the current code path already passes all emitted chunk files to the sourcemap CLI and a directly related fix PR is closed.
Changed files
packages/webpack-plugin/package.jsonpackages/webpack-plugin/src/index.tsValidation