feat: Add request id, version, id, and evaluation reason to $feature_flag_called events #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures backwards compatibility. Reorganize tests and add v4 tests. Move the local eval tests into their own file. Move feature flag tests into `FeatureFlagTest.php`
12 tasks
dmarticus
approved these changes
Apr 17, 2025
Contributor
dmarticus
left a comment
dmarticus
left a comment
There was a problem hiding this comment.
this is banging, nice work! Thanks for getting us up to date on this SDK!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Add support for
/decide?v=4(see PostHog/posthog#29751). Similar to how it's done in PostHog/posthog-js-lite#427.Updates to the
$feature_flag_calledeventWhen capturing the
$feature_flag_calledevent, additional information are now captured:The end result is
$feature_flag_calledevents will have additional properties:$feature_flag_version$feature_flag_reason$feature_flag_id$feature_flag_request_id/deciderequest.Backwards compatibility:
The changes are all backwards compatible with
/decide?v=3.💚 How did you test it?
Unit tests and manual tests.