feat(flags): Implement local evaluation of flag dependencies #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add flag dependencies examples.
haacked
force-pushed
the
haacked/local-evaluation-flag-dependencies
branch
from
688b756 to
9d9d69c
Compare
Update FeatureFlag.php Co-Authored-By: Copilot <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Copilot <175728472+Copilot@users.noreply.github.com>
haacked
force-pushed
the
haacked/local-evaluation-flag-dependencies
branch
from
4ac3e4e to
42821f4
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements local evaluation of feature flag dependencies in the PostHog PHP SDK, enabling complex conditional flags where one flag can depend on the value of another flag. This feature allows for more sophisticated feature rollout strategies and ensures flags can be evaluated locally without additional API calls.
- Adds comprehensive flag dependency evaluation logic with cycle detection
- Implements multivariate flag dependency support for complex chains
- Provides extensive test coverage for all dependency scenarios
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/FeatureFlag.php | Core implementation of flag dependency evaluation with recursion and cycle detection |
| lib/Client.php | Integration of flag dependency context into client evaluation methods |
| test/FlagDependencyTest.php | Unit tests for flag dependency evaluation logic and edge cases |
| test/MultivariateIntegrationTest.php | Integration tests for multivariate flag dependencies |
| test/FlagDependencyIntegrationTest.php | End-to-end integration tests with client API |
| test/FeatureFlagLocalEvaluationTest.php | Updates existing tests to handle new flag dependency behavior |
| example.php | Enhanced examples demonstrating flag dependencies with interactive menu |
| README.md | Updated feature list to highlight flag dependencies |
| .env.example | Configuration template for running examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| public static function matchesDependencyValue($expectedValue, $actualValue) | ||
| { | ||
| // String variant case - check for exact match or boolean true | ||
| if (is_string($actualValue) && strlen($actualValue) > 0) { |
There was a problem hiding this comment.
The empty string check using strlen($actualValue) > 0 is less readable than $actualValue !== ''. Consider using the more explicit comparison for better code clarity.
Suggested change
| if (is_string($actualValue) && strlen($actualValue) > 0) { | |
| if (is_string($actualValue) && $actualValue !== '') { |
andyzzhao
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements local evaluation of flag dependencies. This is is based on the work done for posthog-python in: