fix(flags): fallback to API for multi-condition flags with static cohorts #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orts When a feature flag has multiple conditions and one contains a static cohort, the SDK should fallback to API for the entire flag evaluation instead of skipping the static cohort condition and evaluating subsequent conditions locally. This prevents returning incorrect variants when later conditions match locally but the user is actually in the static cohort. Changes: - Introduce RequiresServerEvaluationException class to distinguish missing server-side data (static cohorts, experience continuity) from evaluation errors (bad regex, invalid dates, missing properties) - Update matchCohort() to throw RequiresServerEvaluationException when cohort not found in local cohorts - Propagate RequiresServerEvaluationException immediately in matchPropertyGroup() and matchFeatureFlagProperties() - Catch RequiresServerEvaluationException in getFeatureFlag(), getAllFlags(), and getFeatureFlagPayload() to trigger API fallback - Add test cases validating multi-condition flags with static cohorts fall back to API and return correct variants and payloads Follows same pattern as Ruby SDK fix: PostHog/posthog-ruby#80
dmarticus
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a feature flag has multiple conditions and one contains a static cohort, the SDK should fallback to API for the entire flag evaluation instead of skipping the static cohort condition and evaluating subsequent conditions locally. This prevents returning incorrect variants when later conditions match locally but the user is actually in the static cohort.
Changes:
Follows same pattern as Ruby SDK fix: PostHog/posthog-ruby#80