Skip to content

Conversation

@dustinbyrne
Copy link
Contributor

This change adds observability into remote feature flag evaluation failures by including a $feature_flag_error property on $feature_flag_called events. The error types are:

Error Type Description
timeout Request timed out (curl errno 28)
connection_error Network connectivity issues (DNS failure, connection refused, etc.)
api_error_{status} API returned HTTP error with status code (e.g., api_error_500)
errors_while_computing_flags Server returned errorsWhileComputingFlags: true
quota_limited Feature flags quota exceeded (quotaLimited contains feature_flags)
flag_missing Requested flag not in API response
unknown_error Unexpected error that doesn't match known patterns

Multiple errors can occur simultaneously and are joined with commas (e.g., errors_while_computing_flags,flag_missing).

@dustinbyrne dustinbyrne force-pushed the feat/feature-flag-error branch 2 times, most recently from 2cb63d6 to 1bd3786 Compare December 19, 2025 20:23
It's due to us requiring error_log_mock
@dustinbyrne dustinbyrne force-pushed the feat/feature-flag-error branch from 1bd3786 to 0500365 Compare December 19, 2025 20:24
@dustinbyrne
Copy link
Contributor Author

Something changed either on the runner or the shivammathur/setup-php@v2 action that's now failing PHP 8.4. As far as I can tell, it's unrelated to this change.

@dustinbyrne dustinbyrne requested a review from a team December 19, 2025 20:39
@dustinbyrne dustinbyrne marked this pull request as ready for review December 19, 2025 20:39
@posthog-project-board-bot posthog-project-board-bot bot moved this from Todo to In Review in Feature Flags Dec 19, 2025
@github-project-automation github-project-automation bot moved this from In Review to Approved in Feature Flags Dec 19, 2025
@dustinbyrne dustinbyrne merged commit 04e4df0 into master Dec 19, 2025
19 of 21 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Feature Flags Dec 19, 2025
@dustinbyrne dustinbyrne deleted the feat/feature-flag-error branch December 19, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants