Skip to content

fix: Clear feature flag called cache on shutdown #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 2 commits into from
Jun 24, 2026
Merged

fix: Clear feature flag called cache on shutdown #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ba78b
fix: Clear feature flag called cache on shutdown
marandaneto Jun 24, 2026
9b37ad0
chore: release posthog-rails for shutdown fix
marandaneto Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/quiet-cycles-shutdown.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"posthog-ruby": patch
Comment thread
marandaneto marked this conversation as resolved.
"posthog-rails": patch
---

Clear the feature flag call dedupe cache on shutdown.
3 changes: 3 additions & 0 deletions lib/posthog/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,9 @@ def shutdown
@worker&.shutdown
@worker_thread&.join(1)
end
@distinct_id_has_sent_flag_calls_mutex.synchronize do
@distinct_id_has_sent_flag_calls.clear
end
end

private
Expand Down
8 changes: 8 additions & 0 deletions spec/posthog/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1534,6 +1534,14 @@ def run
end

describe '#shutdown' do
it 'clears feature flag call dedupe cache' do
client.instance_variable_get(:@distinct_id_has_sent_flag_calls)['user'] = ['flag_true']

client.shutdown

expect(client.instance_variable_get(:@distinct_id_has_sent_flag_calls).length).to eq(0)
end

it 'is idempotent and stops accepting new events' do
worker = instance_spy(PostHog::NoopWorker, is_requesting?: false)
client.instance_variable_set(:@worker, worker)
Expand Down
Loading