Skip to content

chore: use pnpm setup runtime action#199

Merged
marandaneto merged 5 commits into
mainfrom
chore/use-pnpm-setup-runtime
Jun 25, 2026
Merged

chore: use pnpm setup runtime action#199
marandaneto merged 5 commits into
mainfrom
chore/use-pnpm-setup-runtime

Conversation

@marandaneto

@marandaneto marandaneto commented Jun 25, 2026

Copy link
Copy Markdown
Member

💡 Motivation and Context

Simplify CI setup by replacing the separate pnpm/action-setup + actions/setup-node + pnpm cache wiring with the new pinned pnpm/setup action, which installs pnpm and the Node.js runtime in one step.

This also adds/keeps package-manager release-age gates at a total of 7 days:

  • npm .npmrc: min-release-age=7 because npm uses days.
  • pnpm minimumReleaseAge: 10080 because pnpm uses minutes.

Note: pnpm/setup does not currently read .nvmrc, so Node 24 is duplicated in the action config for now where the repo also has .nvmrc. Once jasongin/nvs#315 lands, we can remove that duplicated runtime version and go back to a single .nvmrc source of truth.

💚 How did you test it?

  • Parsed the changed GitHub Actions / pnpm YAML with PyYAML.
  • Checked .npmrc files use npm's day-based min-release-age=7 and pnpm files use minute-based minimumReleaseAge: 10080.
  • Ran git diff --check.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Updated the CI setup at the user's request after checking the new pnpm/setup action behavior. Chose install: false so existing explicit pnpm install --frozen-lockfile commands keep their current lockfile behavior, and pinned the action to the current v1 commit SHA.

@marandaneto marandaneto self-assigned this Jun 25, 2026
@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "chore: use pnpm setup runtime action" | Re-trigger Greptile

@marandaneto marandaneto marked this pull request as ready for review June 25, 2026 08:54
@marandaneto marandaneto requested a review from a team as a code owner June 25, 2026 08:54
@marandaneto marandaneto force-pushed the chore/use-pnpm-setup-runtime branch from c759254 to 497ae41 Compare June 25, 2026 08:58
@marandaneto marandaneto marked this pull request as draft June 25, 2026 09:00
@marandaneto marandaneto marked this pull request as ready for review June 25, 2026 10:47
@marandaneto marandaneto merged commit 50f2432 into main Jun 25, 2026
18 checks passed
@marandaneto marandaneto deleted the chore/use-pnpm-setup-runtime branch June 25, 2026 10:48
@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Security Review

  • Unverified action provenance (.github/workflows/release.yml line 98): pnpm/setup is not the documented official pnpm GitHub Action (pnpm/action-setup is). The version-bump job has contents: write and access to the GitHub App releaser token, making supply-chain provenance of this action critical to verify before merging.

Reviews (2): Last reviewed commit: "fix: use pnpm 11 package manager" | Re-trigger Greptile

- name: Set up pnpm
uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v5.0.0
- name: Set up pnpm and Node.js
uses: pnpm/setup@f7d0e5f4b1b3089d2799ef9722859e7ba314c4c8 # v1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 security Unverified action origin — pnpm/setup vs pnpm/action-setup

The official pnpm action is pnpm/action-setup (documented at pnpm.io and on the GitHub Marketplace). pnpm/setup does not appear in pnpm's official documentation or Marketplace listing. Can you confirm this action lives at github.com/pnpm/setup under the pnpm org and is the intended replacement? This job has contents: write and access to the GitHub App token for pushing to main, so verifying the SHA resolves to a legitimate pnpm-owned repository is important before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants