feat(data-management): add wizard hint to ingestion warnings page#67085
Draft
luke-belton wants to merge 2 commits into
Draft
feat(data-management): add wizard hint to ingestion warnings page#67085luke-belton wants to merge 2 commits into
luke-belton wants to merge 2 commits into
Conversation
Adds an agent-flavored hint above the ingestion warnings table that surfaces the `npx @posthog/wizard ingestion-warnings` command, so users can hand the fix to the wizard instead of tracing each warning back to their code by hand. Mirrors the existing warehouse / MCP hint cards and is hidden on self-hosted (the wizard CLI only targets cloud/dev). Generated-By: PostHog Code Task-Id: 9e7dceff-bc33-4dcd-bf3d-aa14f0abee65
Contributor
|
Reviews (1): Last reviewed commit: "feat(data-management): add wizard hint t..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+342
to
+349
| <CommandBlock | ||
| command={wizardCommand} | ||
| copyLabel="Ingestion warnings wizard command" | ||
| ariaLabel="Copy ingestion warnings wizard command" | ||
| size="sm" | ||
| decoration="rainbow" | ||
| className="bg-surface-secondary border border-primary !m-0 hover:border-accent" | ||
| /> |
Contributor
There was a problem hiding this comment.
WarehouseWizardHint it mirrors fires posthog.capture('warehouse wizard hint command copied') via the onCopy prop whenever the command is copied. Without a corresponding capture here, there will be no telemetry on whether users are actually running the ingestion-warnings wizard, making it impossible to measure adoption.
Suggested change
| <CommandBlock | |
| command={wizardCommand} | |
| copyLabel="Ingestion warnings wizard command" | |
| ariaLabel="Copy ingestion warnings wizard command" | |
| size="sm" | |
| decoration="rainbow" | |
| className="bg-surface-secondary border border-primary !m-0 hover:border-accent" | |
| /> | |
| <CommandBlock | |
| command={wizardCommand} | |
| copyLabel="Ingestion warnings wizard command" | |
| ariaLabel="Copy ingestion warnings wizard command" | |
| size="sm" | |
| decoration="rainbow" | |
| className="bg-surface-secondary border border-primary !m-0 hover:border-accent" | |
| onCopy={() => posthog.capture('ingestion warnings wizard hint command copied')} | |
| /> |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributor
|
Size Change: 0 B Total Size: 65.7 MB ℹ️ View Unchanged
|
Fires a posthog.capture on copy of the ingestion-warnings wizard command, mirroring WarehouseWizardHint, so we can measure adoption of the command. Flagged by Greptile review. Generated-By: PostHog Code Task-Id: 9e7dceff-bc33-4dcd-bf3d-aa14f0abee65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ingestion warnings page tells users which events PostHog had to drop, mis-merge, or degrade — but offers no path to fix them beyond a per-row docs link. These warnings can't be fixed after the fact (the data is already gone); the fix always lives in the instrumentation producing the events.
Changes
Adds an agent-flavored hint card above the warnings table that surfaces the new
npx @posthog/wizard@latest ingestion-warningscommand. The wizard skill queries the project's firing warnings, traces each back to the producing code, and fixes the instrumentation.WarehouseWizardHint/ MCP hint card style (dashed card,AgentBadgeRotator, rainbowCommandBlock).useWizardCommand('ingestion-warnings')hook, so the region flag (--region eu) is handled and it's hidden on self-hosted (no preconfigured wizard endpoint).Backed by the wizard command in PostHog/wizard#775 and the skill in PostHog/context-mill#207.
How did you test this code?
I'm an agent (PostHog Slack app). I have not run the frontend typecheck/format locally — this was authored in a sparse checkout without frontend deps installed, so I relied on matching the existing
WarehouseWizardHintpattern (same imports, props, and Tailwind classes). Needs a CI format/typecheck pass before marking ready.🤖 Agent context
Autonomy: Human-driven (agent-assisted) — requested in the linked Slack thread. DRI should self-assign; I didn't set an assignee because I couldn't verify the requester's GitHub handle this session.
Authored by the PostHog Slack app from a Slack thread. This is one of three PRs implementing the feature end-to-end: the context-mill skill (PostHog/context-mill#207), the wizard command (PostHog/wizard#775), and this page hint. The hint component reuses
useWizardCommandrather than reconstructing the npx command inline, and is non-dismissible (it only renders when warnings exist, so it isn't naggy on a clean project).