fix(audit): stabilize audit check ordering#761
Open
jojosenthusiast wants to merge 1 commit into
Open
Conversation
The audit viewer sorts checks by status then area, but ties on (status, area) fell through to insertion order. The audit skill writes the ledger in whatever sequence it happens to resolve checks, so two runs with identical findings rendered in different positions and the list appeared to rotate between runs. Add id as a final tiebreaker in both `sortChecks` and `groupChecksByArea` so render order is a pure function of the ledger contents. Adds a regression test covering both call sites. Scoped fix: the audit logic for `capture-event-names-static` and `capture-uses-proxy` lives in the external context-mill skill and is out of scope for this repo. Refs: PostHog#736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #736
Summary
Verification
pnpm exec vitest run src/ui/tui/screens/audit/AuditChecksViewer/__tests__/sort.test.ts --reporter=verbosegit diff --check main...HEADRisk
Low. This only changes viewer ordering when checks otherwise have the same status and area.
Note
This handles the wizard-side nondeterministic ordering slice of #736. The false-positive detection logic for
capture-event-names-staticandcapture-uses-proxyappears to live in the context-mill audit bundle rather than this repo, so that needs a separate context-mill follow-up.