-
Notifications
You must be signed in to change notification settings - Fork 26
feat(self-driving): provision an account when no PostHog is found #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rafaeelaudibert
wants to merge
1
commit into
main
Choose a base branch
from
vincent/wizard-self-driving-provisioning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,7 @@ import { | |
| type DiscoveredFeature, | ||
| type PendingQuestion, | ||
| type AskAnswers, | ||
| type CloudRegion, | ||
| AdditionalFeature, | ||
| McpOutcome, | ||
| RunPhase, | ||
|
|
@@ -705,6 +706,29 @@ export class WizardStore { | |
| this.emitChange(); | ||
| } | ||
|
|
||
| /** | ||
| * Self-driving "no PostHog account" branch of the integration check. The | ||
| * project has no SDK, so we always integrate (`integrate = true`); and since | ||
| * the user has no account, we flip `signup` and record the `email` / `region` | ||
| * collected on the screen so `authenticate` → `getOrAskForProjectData` takes | ||
| * the provisioning path (create account + email a login link) instead of | ||
| * OAuth. The "yes, I have an account" branch uses `setIntegrate(true)` and | ||
| * leaves `signup` false so auth runs the normal OAuth login. | ||
| */ | ||
| chooseProvisionAccount(email: string, region: CloudRegion): void { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't like this method name. I understand it's used by the provision path, but this is business logic about how that provisioning works. This business logic should live with the provisioning code and that provisioning code should update the store from there. |
||
| this.$session.setKey('signup', true); | ||
| this.$session.setKey('email', email); | ||
| this.$session.setKey('region', region); | ||
| this.$session.setKey('integrate', true); | ||
| analytics.wizardCapture('self-driving integration check', { | ||
| self_driving_integrate: true, | ||
| self_driving_has_account: false, | ||
| provision_region: region, | ||
| ...sessionProperties(this.session), | ||
| }); | ||
| this.emitChange(); | ||
| } | ||
|
|
||
| /** | ||
| * Self-driving handoff confirmed — the user acknowledged the post-integration | ||
| * screen, so the Self-driving run can begin. Gate resolves via _checkGates(). | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split this UI into it's own component? Flow is confusing to read. This UI shows up after you select log me in vs sign up right?