add: Oidc Connect Discovery#4628
Draft
mkleczek wants to merge 1 commit intoPostgREST:mainfrom
Draft
Conversation
mkleczek
force-pushed
the
work/oidc-connect
branch
from
bb0eeef to
e518608
Compare
Member
|
👀 What's the motivation for this? |
Collaborator
Author
Updated description. |
Comment on lines
+161
to
+162
| , oidc-client >= 0.8.0.0 && < 0.9 | ||
| , http-client-tls >= 0.3.6.4 && < 0.4 |
Member
There was a problem hiding this comment.
http-client-tls is fine, but oidc-client depends on TemplateHaskell, so would block us for #3281 (comment). We should have very good reasons to introduce that without any sane alternatives, because it would effectively prevent us from ever doing cross compilation to platforms without emulator support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLAIMER:
This commit was authored entirely by a human without the assistance of LLMs.Fixes #1130
Fixes #4137
Currently configuring JWT keys is cumbersome and in practice requires implementing Oidc Connect Discovery in a shell script that writes retrieved keys to a file and reloads PostgREST configuration.
Having this implemented in PostgREST would simplify deployment.
OIDC Connect discovery is widely adopted and implemented by practically all OAuth providers (Supabase as well: https://supabase.com/docs/guides/auth/oauth-server#supported-standards)
Next step is to periodically reload keys to facilitate key rotation.