refactor: Extract schemaCacheLoad from retryingSchemaCacheLoad#4856
Draft
mkleczek wants to merge 1 commit intoPostgREST:mainfrom
Draft
refactor: Extract schemaCacheLoad from retryingSchemaCacheLoad#4856mkleczek wants to merge 1 commit intoPostgREST:mainfrom
mkleczek wants to merge 1 commit intoPostgREST:mainfrom
Conversation
This change decouples schema cache loading logic from connection acquisition and retrying logic. Created a new function `schemaCacheLoad :: AppState -> SQL.Session ()` implementing a single schema cache load attempt. The return type is `Hasql.Session` so that it abstracts away connection acquisition and can be easily reused in various context - among others in the Listener thread reusing its database connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLAIMER:
This commit was authored entirely by a human without the assistance of LLMs.
This change decouples schema cache loading logic from connection acquisition and retrying logic.
Created a new function
schemaCacheLoad :: AppState -> SQL.Session ()implementing a single schema cache load attempt. Its return type isHasql.Sessionso that it abstracts away connection acquisition and can be easily reused in various context - among others in the Listener thread reusing its database connection.This PR is a prerequisite to implement schema cache loading from master as discussed in #4842