chore: merge protolude into postgrest by taimoorzaeem · Pull Request #4861 · PostgREST/postgrest

taimoorzaeem · 2026-04-29T10:42:17Z

Towards #4775.

Co-authored-by: Adam Wespiser <adamwespiser@gmail.com>

* Updates README to correctly list all supported stack LTS versions * Updates README to include LTS 19.14 and higher

* Release 0.3.3, with support for GHC 9.4 - allow base-4.18 (GHC 9.4) - allow ghc-prim 0.10 - allow bytestring 0.11.4 - test against GHC 9.4.4 Further CI tweaks: - cabal: update GHC versions to the latest releases of the respective major version - cabal: remove non-latest minor versions - stack: add lts-20 (GHC 9.2.5) - stack: bring the list of GHC versions up to date * Update Cabal CI --------- Co-authored-by: Robert Vollmert <rob@vllmrt.net>

* Test 9.6 and 9.8 in CI * Support GHC 9.10 * Support GHC 9.12 --------- Co-authored-by: Tom Ellis <tom-git@jaguarpaw.co.uk>

wolfgangwalther · 2026-04-29T19:01:56Z

Unfortunately this approach doesn't quite work, yet. When I browse your branch on GitHub, the history/blame for the protolude files only goes back 1 commit - the one where you added the files.

Here's what I'd do:

Add the protolude repo as a remote to my postgrest repo.
Create a new branch off of their latest default branch.
Create a commit to move all files on that branch into src/protolude or so.
Create a new branch off of postgrest's main branch.
Merge the protolude branch into this new branch with a merge commit.
Create a .git-blame-ignore-revs file at the top-level and add the commit hash of the commit that moved files into src/protolude to it to keep the git blame clean.
Then add a commit to integrate the new protolude lib into our build etc.

Later we merge the src/protolude directory with src/PostgREST. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>

Ignore blame for commit that moved protolude files under src/protolude. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>

taimoorzaeem · 2026-04-30T09:34:06Z

Here's what I'd do:

Add the protolude repo as a remote to my postgrest repo.

....

Then add a commit to integrate the new protolude lib into our build etc.

Right, your approach looks good. Thank you for sharing this. 👍

Roadmap

Pull protolude source
Merge with postgrest
Create .git-blame-ignore-revs
Remove unneeded files and integrate protolude with PostgREST build

wolfgangwalther · 2026-04-30T09:45:24Z

Did a quick check: Browsing your branch on GitHub now correctly tracks commit information, I can easily blame my way through. Nice.

Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>

Currently, our vendored protolude has many failing checks for style, lint and hsie. Temporarily excluding it. We should reinstate these checks later. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>

taimoorzaeem · 2026-04-30T17:05:56Z

Looks like there is a GHC 9.12.3 bug that only shows up when we build PostgREST with --enable-profiling also enabled for protolude.

Compiling PostgREST.Config.Proxy ( src/PostgREST/Config/Proxy.hs, dist-prof/build/x86_64-linux/ghc-9.12.3/postgrest-15/build/PostgREST/Config/Proxy.o, dist-prof/build/x86_64-linux/ghc-9.12.3/postgrest-15/build/PostgREST/Config/Proxy.dyn_o )
<no location info>: error:
    panic! (the 'impossible' happened)
  GHC version 9.12.3:
	lookupGREInfo
  lookup failed: toS
  Call stack:
      CallStack (from HasCallStack):
        callStackDoc, called at compiler/GHC/Utils/Panic.hs:190:37 in ghc-9.12.3-2625:GHC.Utils.Panic
        pprPanic, called at compiler/GHC/Rename/Env.hs:2026:15 in ghc-9.12.3-2625:GHC.Rename.Env

Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug

wolfgangwalther · 2026-05-01T07:57:22Z

I'm not sure whether it'd be helpful to go on with the coverage-based removal of protolude code first to simplify that code-base. Maybe we then have a better chance of diagnosing this problem?

Other ideas to go on from here:

ofc, actually report the bug upstream! Would probably need to confirm this with 9.12.4 first?
try building protolude in its own repo upstream with enable-profiling, see whether the problem persists

taimoorzaeem · 2026-05-01T14:36:54Z

I'm not sure whether it'd be helpful to go on with the coverage-based removal of protolude code first to simplify that code-base. Maybe we then have a better chance of diagnosing this problem?

Not sure about that either, but I will try to look into it.

ofc, actually report the bug upstream! Would probably need to confirm this with 9.12.4 first?

I confirmed the error with 9.12.4 in my fork. Bug reported: https://gitlab.haskell.org/ghc/ghc/-/issues/27227

try building protolude in its own repo upstream with enable-profiling, see whether the problem persists

On my system it builds just fine. I think the profiled build is probably not the problem because it also fails in the regular build in NixOS - MacOS build in CI.

taimoorzaeem · 2026-05-06T12:13:39Z

GHC team traced this issue to haskell/cabal#7684. Looks like PR: haskell/cabal#11791 has been opened to fix the issue 🎉 .

sdiehl added 30 commits June 8, 2016 19:38

Explicit Typeable for older GHC.

6ae19be

DeriveTyepable pragma.

6edc320

Remove string-conv dependency.

a9c8d30

Debug functions to use Text.

30d0bbc

Read actions for Strict text in scope by default.

173b86d

IO handle functions.

78b16eb

Remove printf.

8d794da

Symbols list.

e0cace8

Dependencies note.

b680551

github table formatting

dce9f0c

Don't support alternative Base.

0aa40b8

Fix up bound documentation.

a7bc404

MOre specializers.

e2b886b

FAQ section.

f4178f0

Added changelog.

22c0e74

Added changelog.

fa58c54

Callstack for GHC 8.x.

205643e

Remove throw and assert exports.

cef28ed

Remove showCallStack.

cf1fa98

Single SrcLoc export.

89fdc58

Move throw to Unsafe exports.

b8479eb

Control.Exception as qualified import.

c2ca167

Encoding functions in scope by default.

63d5ed6

Change safety language flags.

f6586ba

Add unsnoc function.

f0fd117

Fix 0.1.6 changelog.

21be7f2

Note about exception handling.

6b6f896

Formatting for FAQ.

827c0ef

Better example text for panic.

b621258

Note explicit String types.

b658b4c

luc-tielen and others added 11 commits February 21, 2022 14:38

Add HasCallStack to unsafe* functions (#129)

f8cf137

Co-authored-by: Adam Wespiser <adamwespiser@gmail.com>

Fix Hackage Formatting (#134)

3611929

Re-export isInfixOf, isSuffixOf from Data.List, Issue #119 (#135)

1b453b6

0.3.1 Release (#133)

3e24972

0.3.2 Release (#127) (#138)

e40b735

Updates README to correctly list all supported stack LTS versions (#140)

cd83ebe

* Updates README to correctly list all supported stack LTS versions * Updates README to include LTS 19.14 and higher

Make it build with ghc 9.8 (update deps only) (#146)

5a98f0c

0.3.4 release (#148)

20f2e89

Support GHC 9.12 (#151)

daad7c3

* Test 9.6 and 9.8 in CI * Support GHC 9.10 * Support GHC 9.12 --------- Co-authored-by: Tom Ellis <tom-git@jaguarpaw.co.uk>

bump version 0.3.5 (#152)

a4880f0

taimoorzaeem marked this pull request as draft April 29, 2026 10:42

steve-chavez mentioned this pull request Apr 29, 2026

Move away from protolude and create our own Prelude #4775

Open

taimoorzaeem added 2 commits April 30, 2026 14:16

chore: move protolude files to src/protolude

d4949c6

Later we merge the src/protolude directory with src/PostgREST. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>

chore: merge protolude as subdirectory src/protolude

827121b

taimoorzaeem force-pushed the prelude/protolude/master branch from 7a4adb2 to 827121b Compare April 30, 2026 09:21

chore: add .git-blame-ignore-revs

7c8f79d

Ignore blame for commit that moved protolude files under src/protolude. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>

taimoorzaeem added 3 commits April 30, 2026 15:38

chore: remove unneeded files and directories from src/protolude

3665027

Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>

chore: build postgrest with vendored protolude

a2faa66

Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>

nix: exclude protolude from style checks

a46ac79

Currently, our vendored protolude has many failing checks for style, lint and hsie. Temporarily excluding it. We should reinstate these checks later. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>

taimoorzaeem force-pushed the prelude/protolude/master branch from 718c1e0 to a46ac79 Compare April 30, 2026 15:33

taimoorzaeem marked this pull request as ready for review April 30, 2026 15:40

taimoorzaeem marked this pull request as draft May 1, 2026 12:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: merge protolude into postgrest#4861

chore: merge protolude into postgrest#4861
taimoorzaeem wants to merge 306 commits intomainfrom
prelude/protolude/master

taimoorzaeem commented Apr 29, 2026

Uh oh!

wolfgangwalther commented Apr 29, 2026

Uh oh!

taimoorzaeem commented Apr 30, 2026 •

edited

Loading

Uh oh!

wolfgangwalther commented Apr 30, 2026

Uh oh!

taimoorzaeem commented Apr 30, 2026 •

edited

Loading

Uh oh!

wolfgangwalther commented May 1, 2026

Uh oh!

taimoorzaeem commented May 1, 2026

Uh oh!

taimoorzaeem commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

taimoorzaeem commented Apr 29, 2026

Uh oh!

wolfgangwalther commented Apr 29, 2026

Uh oh!

taimoorzaeem commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Roadmap

Uh oh!

wolfgangwalther commented Apr 30, 2026

Uh oh!

taimoorzaeem commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfgangwalther commented May 1, 2026

Uh oh!

taimoorzaeem commented May 1, 2026

Uh oh!

taimoorzaeem commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

20 participants

taimoorzaeem commented Apr 30, 2026 •

edited

Loading

taimoorzaeem commented Apr 30, 2026 •

edited

Loading