Fix PAC CLI detection for VS Code extension installations (#76)

* Initial plan

* Implement PAC CLI detection for VS Code extension

Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>

* Add session caching for detected PAC path

Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>

Author: Copilot

Maverick.PCF.Builder.Helper/Commands.cs

@@ -154,6 +154,16 @@ public static string Check()
                 return $"pac";
             }
 
+            /// <summary>
+            /// Check PAC using custom path
+            /// </summary>
+            /// <param name="pacPath">Full path to pac.exe</param>
+            /// <returns></returns>
+            public static string Check(string pacPath)
+            {
+                return $"\"{pacPath}\"";
+            }
+
             /// <summary>
             /// pac auth create --url <https://xyz.crm.dynamics.com>
             /// </summary>

Maverick.PCF.Builder/PCFBuilder.cs

@@ -34,6 +34,7 @@ public partial class PCFBuilder : PluginControlBase, IGitHubPlugin, IHelpPlugin,
     {
         #region XrmToolBox settings
         private Settings pluginSettings;
+        private string detectedPacPath; // Cache the detected PAC path for session reuse
 
         public string RepositoryName => "PCF-CustomControlBuilder";
         public string UserName => "Power-Maverick";
@@ -810,8 +811,30 @@ public void CheckPacVersion(object worker, DoWorkEventArgs args)
         {
             var start = DateTime.Now;
 
-            string[] commands = new string[] { Commands.Pac.Check() };
-            var output = CommandLineHelper.RunCommand(commands);
+            // Try to find PAC in multiple locations
+            string pacPath = FindPacPath();
+            string[] commands;
+            string output;
+
+            if (!string.IsNullOrEmpty(pacPath))
+            {
+                // Use the found PAC path
+                if (pacPath.Equals("pac", StringComparison.InvariantCultureIgnoreCase))
+                {
+                    commands = new string[] { Commands.Pac.Check() };
+                }
+                else
+                {
+                    commands = new string[] { Commands.Pac.Check(pacPath) };
+                }
+                output = CommandLineHelper.RunCommand(commands);
+            }
+            else
+            {
+                // Fallback to standard check for backward compatibility
+                commands = new string[] { Commands.Pac.Check() };
+                output = CommandLineHelper.RunCommand(commands);
+            }
 
             StringHelper stringer = new StringHelper();
             PacVersionParsedDetails outputParsedPacDetails = stringer.ParsePacVersionOutput(output);
@@ -944,6 +967,56 @@ private string FindMsBuildPath()
             return msBuildPath;
         }
 
+        private string FindPacPath()
+        {
+            // Return cached path if available
+            if (!string.IsNullOrEmpty(detectedPacPath))
+            {
+                return detectedPacPath;
+            }
+
+            // First try the standard PAC command (global installation)
+            string[] standardCommands = new string[] { Commands.Pac.Check() };
+            var standardOutput = CommandLineHelper.RunCommand(standardCommands);
+
+            StringHelper stringer = new StringHelper();
+            PacVersionParsedDetails standardPacDetails = stringer.ParsePacVersionOutput(standardOutput);
+
+            // If PAC is found via standard command, use it
+            if (!standardPacDetails.CLINotFound)
+            {
+                detectedPacPath = "pac"; // Cache the result
+                return detectedPacPath;
+            }
+
+            // Try VS Code extension location
+            try
+            {
+                string appDataPath = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);
+                string vscodeExtensionPacPath = Path.Combine(appDataPath, "Code", "User", "globalStorage", "microsoft-isvexptools.powerplatform-vscode", "pac", "tools", "pac.exe");
+                
+                if (File.Exists(vscodeExtensionPacPath))
+                {
+                    // Test if this PAC installation works by running it
+                    string[] vscodeCommands = new string[] { Commands.Pac.Check(vscodeExtensionPacPath) };
+                    var vscodeOutput = CommandLineHelper.RunCommand(vscodeCommands);
+                    
+                    PacVersionParsedDetails vscodePacDetails = stringer.ParsePacVersionOutput(vscodeOutput);
+                    if (!vscodePacDetails.CLINotFound)
+                    {
+                        detectedPacPath = vscodeExtensionPacPath; // Cache the result
+                        return detectedPacPath;
+                    }
+                }
+            }
+            catch (Exception)
+            {
+                // If there's any error accessing the VS Code extension path, continue with standard behavior
+            }
+
+            return string.Empty; // PAC not found in any location
+        }
+
         private void IncrementComponentVersion()
         {
             var start = DateTime.Now;