Skip to content

Conversation

@romeroalx
Copy link
Member

Short description

This PR tries to simplify the location of dependencies for this tool to only requirements.txt. Also updates setup.py to consider that the requirements file could include hashes (pip-compile output).

The reason for this PR is that dependabot found a couple of security issues for the packages pinned in Pipfile.lock that was initially generated for Python 3.7`. See #16605 and #15648.

A simple test to check that the package builds correctly:

docker run -ti python:3.11-slim-trixie bash
apt update && apt install git curl -y
cd
git clone --recursive https://github.com/romeroalx/pdns.git
cd pdns/pdns/keyroller/
git checkout keyroller-remove-pipfile
python -m venv venv
. venv/bin/activate
pip install .

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@romeroalx romeroalx requested a review from Habbie December 9, 2025 13:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20066002400

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 65 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+5.2%) to 73.328%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/recursordist/lwres.cc 2 65.82%
modules/gpgsqlbackend/spgsql.cc 3 68.42%
pdns/rcpgenerator.cc 3 90.87%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/recursordist/syncres.cc 5 80.95%
pdns/recursordist/test-syncres_cc1.cc 7 90.26%
pdns/recursordist/rec-tcp.cc 14 69.45%
modules/godbcbackend/sodbc.cc 26 70.08%
Totals Coverage Status
Change from base Build 20064863395: 5.2%
Covered Lines: 128797
Relevant Lines: 164859

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants