-
Notifications
You must be signed in to change notification settings - Fork 14
feat: iterate over shortest path #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaapschoutenalliander
wants to merge
20
commits into
main
Choose a base branch
from
feature/iter_path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
28f8e3e
feat: iter branches
jaapschoutenalliander 102c280
feat: add grid repr method
jaapschoutenalliander ff85f14
feat: add grid repr method
jaapschoutenalliander 5baeaf7
chore: docs
jaapschoutenalliander 1761bb8
chore: docs
jaapschoutenalliander a4a1c0e
feat: typed
jaapschoutenalliander 5cdbb67
feat: docs
jaapschoutenalliander d5e2c8f
test: add test for typed threewinding
jaapschoutenalliander c98798a
docs: setup feeder ids notebook
jaapschoutenalliander 42ec97a
feat: active branches filtering
jaapschoutenalliander 8baba8d
chore: mypy
jaapschoutenalliander 0e681c6
chore: copilot review
jaapschoutenalliander 441e2c5
docs: clarify docstring
jaapschoutenalliander 5c3734b
feat: simplify three winding lookup
jaapschoutenalliander 6e15083
simplify function
vincentkoppen 5277f52
Merge branch 'main' of github.com:PowerGridModel/power-grid-model-ds …
vincentkoppen 06ab70f
naming
vincentkoppen e78ccbd
feat: only typed
jaapschoutenalliander 6cec22c
chore: update with main
jaapschoutenalliander 3d894fd
chore: order
jaapschoutenalliander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding test coverage for the MissingBranchError case that would be raised at line 142 of _search.py. This would happen when the graph reports a path but no active branch exists between consecutive nodes, which could occur if the graph state is inconsistent with the branch data. A test would help ensure this error is raised with a clear message in such edge cases.