feat: add prediction card touch ripple feedback#427
Open
pq198363-ops wants to merge 1 commit into
Open
Conversation
|
@pq198363-ops is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
touch-ripplepress feedback forPredictionCardusing a CSS pseudo-element on:activeprefers-reduced-motionand keep the existing 44px touch target/focus ring behaviorPredictionCardtest file, cover ripple CSS/classes, and remove the extensionlesscomponents/predictioncardfile that shadowsPredictionCard.tsxon Windows/Jest resolutiondocs/touch-ripple.mdCloses #363
Verification
node node_modules/jest/bin/jest.js components/__tests__/PredictionCard.test.tsx --runInBandpassed: 12 testsnode node_modules/eslint/bin/eslint.js components/PredictionCard.tsx components/__tests__/PredictionCard.test.tsxexited 0 with one pre-existing@next/next/no-img-elementwarning inPredictionCard.tsxgit diff --checkexited 0Known baseline issues
node node_modules/typescript/bin/tsc --noEmitstill fails on unrelated existing files such as dashboard layout, wallet modal, disputes badges, navbar, and dialog code.getKitand events table accessibility expectations.