Skip to content

Conversation

@iamadlx
Copy link

@iamadlx iamadlx commented Feb 9, 2026

Added JSON-LD structured data for FAQ rich snippets.

Added JSON-LD structured data for FAQ rich snippets.
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f0a2a6612

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 33 to 36
"name": "{$faq.question|strip_tags|escape:'htmlall':'UTF-8'}",
"acceptedAnswer": {literal}{{/literal}
"@type": "Answer",
"text": "{$faq.answer|strip_tags|escape:'htmlall':'UTF-8'}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Escape FAQ values with JSON-safe encoding

The structured data strings are escaped with escape:'htmlall', which is HTML escaping rather than JSON escaping. This can emit invalid JSON when FAQ content includes JSON-significant characters (for example a backslash in C:\Temp or control characters), causing the application/ld+json block to fail parsing and preventing FAQ rich results from being recognized.

Useful? React with 👍 / 👎.

Copy link
Author

@iamadlx iamadlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit with codex suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant